[openxr-loader] update to 1.1.45 and get error: Python 3 not found

[JonLiu1993]

Hi, when I update openxr-loader to the latest version 1.1.45, I get this error in vcpkg test pipline:
microsoft/vcpkg#43763

CMake Error at src/CMakeLists.txt:433 (message):
  Python 3 not found, but pre-generated
  D:/b/openxr-loader/src/ase-1.1.45-1760c881e2.clean/src/xr_generated_dispatch_table.h
  not found

I noticed in the vcpkg portfile.cmake there already have pass option "-DPYTHON_EXECUTABLE=${PYTHON3}",
So I add "-DPython3_EXECUTABLE=${PYTHON3}" fix this error, I want to know the latest version openxr-loader need pass all option? Thanks!

[dg0yt]

IOW there is inconsistent use of CMake python modules and variables. It would be great to see consistency restored.

[rpavlik]

We switched from the deprecated way of finding the Python interpreter to the current recommended one, see #486

So yes, if Python cannot be found by default, the config variable to pass has indeed changed, to match other CMake based builds.

Does this answer your question?

[dg0yt]

Update: AFAIU PYTHON_EXECUTABLE still occurs in test-related third-party code. In some cases it seems to be initialized from Python3_EXECUTABLE. I do not know if this covers all cases.
https://github.com/search?q=repo%3AKhronosGroup%2FOpenXR-SDK-Source%20PYTHON_EXECUTABLE&type=code

This code is not used in vcpkg. In fact, the vcpkg build clearly reports that PYTHON_EXECUTABLE is not used in that configuration, and the issue is obsolete from the vcpkg POV.

[rpavlik]

The code in that code search is self-test code from dependencies that is never built in OpenXR, so PYTHON_EXECUTABLE should not ever be used in the build or need to be set. it is consistent and that fix resolved some deprecation warnings.

So what needs to be done to fix this issue? I'm not sure what the repro steps or success criteria are here.

(While I use vcpkg, I do not usually use the OpenXR loader from vcpkg. We do ship binaries with CMake configuration files with each release, though I have no idea if anyone actually uses them.)

[dg0yt]

No fix needed here. You may close the issue.

[rpavlik]

Great, thanks for the confirmation.