-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Future plans? #2
Comments
Hey there 1/ Eventually, when it's ready There are 2 main issues:
Until Facebook makes it less risky to use GraphQL, I don't think I really want to dedicate time to it though. The license should be MIT. |
Fair enough. Hopefully, patent situation will fix soon
Yes, grammar is a bit more concise when using pest, but there is also a conversion stage, as far as I can see. While when using combine you get AST straight from parser. This is just FYI, I'm not insisting on it. |
For the patent situation there is an issue: graphql/graphql-spec#351 but no answers so far |
The license has been changed to MIT! |
Hi,
I'm looking if I can use the library for my own purposes. So my questions are:
combine
crate more thanpest
, because former doesn't parse grammar in runtime and also returns ready to use AST after parsing (i.e. you put AST nodes to convert to as part of the rules). Have you seen it? Is there any reasons you use pest? (not that it's requirements, just asking)The (3) may need more explanation. Firstly, it's important for error reporting. Second thing is that my use case is rewriting queries and map error positions back to original ones. So at least I need not just position where query or field is but also a position of a closing brace
}
(i.e. start and end of every node). And may be up to the whole CST, I'm not sure yet.Overall I like this crate more than other ones, so looking forward to some cooperation.
P.S.: by the way, there is no license.
The text was updated successfully, but these errors were encountered: