Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix URI encoding on URL query #306

Closed
kdevbot bot opened this issue Apr 1, 2024 · 0 comments · Fixed by #309
Closed

Fix URI encoding on URL query #306

kdevbot bot opened this issue Apr 1, 2024 · 0 comments · Fixed by #309
Assignees
@Katsute
Labels
bug vscode

Comments

@kdevbot
Copy link
Contributor

kdevbot bot commented Apr 1, 2024 •
edited by Katsute
Loading

encodeURI is incorrect and should be encodeURIComponent

Can not be fixed yet, VSCode openExternal keeps decoding encoded URIs preventing the URL from working properly.

KNOWN AND UNFIXED SINCE 2019.

Possible fix: microsoft/vscode#85930 (comment)
@Katsute Katsute self-assigned this Apr 1, 2024
@Katsute Katsute changed the title issue Fix URI encoding on URL query Apr 1, 2024
@Katsute Katsute mentioned this issue Apr 2, 2024
Merged
@kdevbot kdevbot bot locked and limited conversation to collaborators Apr 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Katsute Katsute

Labels
bug vscode
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug report button when using CSS KatsuteDev/Background
1 participant
@Katsute