Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Localization concern to send Content-Language #588

Closed
Kaliumhexacyanoferrat opened this issue Dec 12, 2024 · 1 comment · Fixed by #596
Closed

Allow Localization concern to send Content-Language #588

Kaliumhexacyanoferrat opened this issue Dec 12, 2024 · 1 comment · Fixed by #596
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@Kaliumhexacyanoferrat
Copy link
Owner

As a client, I would like to know the actual language/locale that was used by the server to generate my content.

Example

By default, the server will send the Content-Language that was negotiated (only if there was an Accept-Language), but users may opt out:

Localization.Create()
            .SendLanguage(false);

Acceptance criteria

  • If the requests contains an Accept-Language header, the server will generate a Content-Language header in response
  • The feature is documented on the GenHTTP website
  • The feature is covered by acceptance tests
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat added enhancement New feature or request good first issue Good for newcomers labels Dec 12, 2024
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat self-assigned this Dec 16, 2024
@Kaliumhexacyanoferrat Kaliumhexacyanoferrat added this to the Version 9.4 milestone Dec 16, 2024
@Kaliumhexacyanoferrat
Copy link
Owner Author

Just send it always and also when it is not read from the Accept-Language header ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant