Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add autocomplete attribute to input and textarea #321

Merged
merged 4 commits into from
Nov 21, 2024

Conversation

pixelflips
Copy link
Member

@pixelflips pixelflips commented Nov 20, 2024

Description

Adds an autocomplete prop and attribute to pds-input and pds-textarea components.
This allows the developer to control the autocomplete behavior and information.

Fixes: https://kajabi.atlassian.net/browse/DSS-1174

Type of change

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Navigate to Input and Textarea
Verify that setting the autocomplete prop passes down the value to the appropriate input.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Nov 20, 2024
@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Nov 20, 2024
Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 69e4e9d
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/673e0ca52f383b0008c5308f
😎 Deploy Preview https://deploy-preview-321--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pixelflips pixelflips marked this pull request as ready for review November 20, 2024 00:43
@pixelflips pixelflips requested a review from a team November 20, 2024 00:44
@ju-Skinner
Copy link
Collaborator

Can we add a autocomplete story for each of the form components you added this to?

@pixelflips
Copy link
Member Author

Can we add a autocomplete story for each of the form components you added this to?

@ju-Skinner done.

@pixelflips pixelflips requested review from a team and removed request for a team November 20, 2024 20:29
@pixelflips pixelflips requested a review from a team November 20, 2024 20:33
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Given

@pixelflips pixelflips merged commit 0b9c108 into main Nov 21, 2024
16 checks passed
@pixelflips pixelflips deleted the fix/add-autocomplete-attribute branch November 21, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants