Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adds tooltip max width prop and removes events #285

Merged
merged 6 commits into from
Nov 7, 2024

Conversation

pixelflips
Copy link
Member

Description

This PR adds a maxWidth prop to the pds-tooltip component, allowing users to set a maximum width for the tooltip content. It also sets the default to 352px as defined by the design team.

In addition, as previously discussed by the team, events have been removed.

Fixes:
https://kajabi.atlassian.net/browse/DSS-1151
https://kajabi.atlassian.net/browse/DSS-1158

Type of change

Please delete options that are not relevant.
If your type of change is not present, add that option.

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • Navigate to tooltip

  • Verify maxWidth is applied properly when added.

  • Verify UI changes as expected

  • Verify documentation additions/updates are clear.

  • unit tests

  • e2e tests

  • accessibility tests

  • tested manually

  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Nov 7, 2024
@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Nov 7, 2024
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 675988c
🔍 Latest deploy log https://app.netlify.com/sites/pine-design-system/deploys/672d1488632fcc00088bcf8a
😎 Deploy Preview https://deploy-preview-285--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pixelflips pixelflips requested a review from a team November 7, 2024 20:28
@@ -37,6 +37,7 @@
box-shadow: var(--box-shadow-default);
color: var(--color-text-default);
// TODO: need to use block / none but the tooltip content width and height are needed for calculations
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what this TODO is for and are we able to clean this up while we are in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monicawheeler TBH, I have no idea but will check into it.

Copy link
Contributor

@monicawheeler monicawheeler Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe @QuintonJason could help -> 84f6259

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already pinged him!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@monicawheeler checked in with @QuintonJason and that comment ties into the universal approach of how tooltip, dropdown, popover will work. Quinton will be following up here as well as he begins work on the other mentioned components, so no action needed in this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow up!

@monicawheeler monicawheeler requested a review from a team November 7, 2024 20:34
@pixelflips pixelflips merged commit 9a32fbe into main Nov 7, 2024
16 checks passed
@pixelflips pixelflips deleted the fix/tooltip-max-width-and-events-removal branch November 7, 2024 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working package: core Changes have been made to the Core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants