Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails without error if pkgbuild file is not named "PKGBUILD" #44

Closed
pol-rivero opened this issue Feb 10, 2025 · 3 comments · Fixed by #45
Closed

Fails without error if pkgbuild file is not named "PKGBUILD" #44

pol-rivero opened this issue Feb 10, 2025 · 3 comments · Fixed by #45

Comments

@pol-rivero
Copy link
Contributor

In this line, the provided PKGBUILD file is copied to /tmp/local-repo without modifying its name. This causes the subsequent steps to not work properly if the filename is not exactly "PKGBUILD" (for example, when publishing multiple packages at once). Additionally, there is no error message.

I believe this line cp -r "$pkgbuild" /tmp/local-repo/ should be changed to cp "$pkgbuild" /tmp/local-repo/PKGBUILD. This, of course, could break the workflows of those who passed a directory instead of a file in $pkgbuild and relied on the old behavior to copy its contents, but the description of the pkgbuild parameter is "Path to PKGBUILD file", which makes it clear that you should pass a single file instead of a directory, and they should be using assets instead.

I'm creating an issue instead of a PR because I'm not sure if my reasoning is correct, and maybe this breaks something else.

@KSXGitHub
Copy link
Owner

Your reasoning is correct. I'll be waiting for a PR.

@pol-rivero
Copy link
Contributor Author

Sure thing, here you go #45

@KSXGitHub
Copy link
Owner

v4.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants