Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to delete non-empty folders after uninstall in the ConsoleUI #3484

Closed
The0n1y5pace4ce opened this issue Nov 21, 2021 · 2 comments · Fixed by #4066
Closed

Prompt user to delete non-empty folders after uninstall in the ConsoleUI #3484

The0n1y5pace4ce opened this issue Nov 21, 2021 · 2 comments · Fixed by #4066
Labels
ConsoleUI Issues affecting the interactive console UI Enhancement New features or functionality macOS Issues specific for macOS

Comments

@The0n1y5pace4ce
Copy link

The0n1y5pace4ce commented Nov 21, 2021

Background

  • Operating System: macOS
  • CKAN Version: Hubble
  • KSP Version: 1.12.2

Have you made any manual changes to your GameData folder (i.e., not via CKAN)?

Yes, other mods not included in the macOS version of CKAN

Problem

Describe the bug
Dont know if this counts as a bug, but when un installing a mod installed via CKAN, the proper mod folders are kept, but the contents on them are removed except for the @thumbs folder inside the parts folder, this does not affect me physically, but can make it harder to manage my gamedata folder

Steps to reproduce

  • Go to CKAN and uninstall a mod installed through CKAN
  • Click on gamedata and then you will still see the folder

Expected behavior

The @thumbs folder in the parts is there, nothing in it, nothing around it

@DasSkelett
Copy link
Member

DasSkelett commented Nov 21, 2021

CKAN does not remove files it didn't install by default, the @thumbs directories and their content are created dynamically when the game is running.
Since #2962 the GUI asks whether to remove remaining files and folders.
This feature doesn't exist in the console UI yet, which I suspect you are using, as you mention "the macOS version of CKAN".

It might be time to add it as well, given how much we rely on the console UI now on macOS. I'm going to label this as feature request.

@DasSkelett DasSkelett added ConsoleUI Issues affecting the interactive console UI Enhancement New features or functionality macOS Issues specific for macOS labels Nov 21, 2021
@DasSkelett DasSkelett changed the title [Bug] Mods Uninstalled via CKAN Still having the main folder there Prompt user to delete non-empty folders after uninstall in the ConsoleUI Nov 21, 2021
@HebaruSan
Copy link
Member

The core idea of this enhancement is still valid, but #3890 added auto-deletion of game-created @thumbs folders.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ConsoleUI Issues affecting the interactive console UI Enhancement New features or functionality macOS Issues specific for macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants