Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for HalfIntegers? #5

Open
jagot opened this issue Aug 29, 2022 · 2 comments
Open

Support for HalfIntegers? #5

jagot opened this issue Aug 29, 2022 · 2 comments

Comments

@jagot
Copy link

jagot commented Aug 29, 2022

Would it be interesting to support HalfIntegers.jl?

Currently, I see the following:

julia> using HalfIntegers, RationalRoots

julia> signedroot(half(1))
0.7071067811865476

julia> signedroot(Rational(half(1)))
+√(1//2)
@Jutho
Copy link
Owner

Jutho commented Jan 5, 2024

Is this very important? Since there is no AbstractRational it is not so easy to do this. A package extension could be used, but that seems overkill.

I tried with signedroot(RationalRoot, half(1)), but that does not work because Base.rationalize(::HalfInteger) is not defined. That would probably be a useful addition to HalfIntegers.jl

@jagot
Copy link
Author

jagot commented Jan 5, 2024

Probably not very important :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants