Fix treat_as_own

[lgoettgens]

Due to a dumb typo on my side (which I definitely should have noticed), the test_piracy kwarg treat_as_own is broken in the 0.6.4 release. This fixes it. I propose the following line of action:

• Yank 0.6.4 or just ignore it as we have a newer release anyway (see point 3).
• Merge Revert "Enhance test_ambiguities" #152 to revert the breaking change.
• Merge this PR.
• Make a new release.
• Revert Revert "Enhance test_ambiguities" #152 to again include the breaking change.

Is this fine for you @fingolfin ?

[codecov]

Codecov Report

Merging #153 (48bb498) into release-0.6 (c7eb4d4) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##           release-0.6     #153   +/-   ##
============================================
  Coverage        77.14%   77.14%           
============================================
  Files               11       11           
  Lines              722      722           
============================================
  Hits               557      557           
  Misses             165      165           

Flag	Coverage Δ
unittests	77.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/piracy.jl	91.04% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[fingolfin]

Is anything broken in 0.6.4 other than the new treat_as_own? If not, then I see no reason to yank it, that'd be a rather drastic measure.

[fingolfin]

Also we don't need #152, we can just work with a release branch. I'll take care of it.

[lgoettgens]

Also we don't need #152, we can just work with a release branch. I'll take care of it.

Thanks!

[dhanak]

Alas, treat_as_own is still broken in v0.6.6.

$ julia --project -e "using Pkg; Pkg.test()"
...
  [4c88cf16] Aqua v0.6.6
...
Error During Test at /home/david/.julia/packages/Aqua/VwSn1/src/Aqua.jl:118
  Got exception outside of a @test
  UndefRefError: access to undefined reference
  Stacktrace:
    [1] getproperty
      @ ./Base.jl:33 [inlined]
    [2] is_foreign_method(T::DataType, pkg::Base.PkgId; treat_as_own::Vector{Union{Function, Type}})
      @ Aqua.Piracy ~/.julia/packages/Aqua/VwSn1/src/piracy.jl:143
    [3] is_foreign_method(T::DataType, pkg::Base.PkgId; treat_as_own::Vector{Union{Function, Type}})
      @ Aqua.Piracy ~/.julia/packages/Aqua/VwSn1/src/piracy.jl:139
    [4] is_pirate(meth::Method; treat_as_own::Vector{Union{Function, Type}})
      @ Aqua.Piracy ~/.julia/packages/Aqua/VwSn1/src/piracy.jl:156
    [5] is_pirate
      @ ~/.julia/packages/Aqua/VwSn1/src/piracy.jl:149 [inlined]
...

I believe this is the same issue. v0.6.3 is the last version my test works with.

(This is Julia v1.8.5, but the same issue occurs with v1.7.3 as well.)

[fingolfin]

@dhanak if you believe there is still a problem, please open an issue, with details so we can reproduce it (in particular, how you invoked Aqua and on which code)

[dhanak]

#167 - I found a minimal working example.