Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not report stale deps that are weakdeps as well #135

Merged
merged 1 commit into from
Jun 5, 2023

Conversation

lgoettgens
Copy link
Collaborator

Resolves #107.

@codecov
Copy link

codecov bot commented Jun 5, 2023

Codecov Report

Merging #135 (890b3be) into master (e463b90) will increase coverage by 0.31%.
The diff coverage is 100.00%.

❗ Current head 890b3be differs from pull request most recent head b849b74. Consider uploading reports for the commit b849b74 to get more accurate results

@@            Coverage Diff             @@
##           master     #135      +/-   ##
==========================================
+ Coverage   75.34%   75.66%   +0.31%     
==========================================
  Files          11       11              
  Lines         718      715       -3     
==========================================
  Hits          541      541              
+ Misses        177      174       -3     
Flag Coverage Δ
unittests 75.66% <100.00%> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Aqua.jl 68.96% <100.00%> (+0.39%) ⬆️
src/stale_deps.jl 97.56% <100.00%> (+0.19%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

src/stale_deps.jl Outdated Show resolved Hide resolved
Copy link
Member

@fingolfin fingolfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lgoettgens lgoettgens force-pushed the lg/stale-weakdeps branch from 890b3be to b849b74 Compare June 5, 2023 13:39
@fingolfin fingolfin merged commit b6771e6 into JuliaTesting:master Jun 5, 2023
@fingolfin
Copy link
Member

Thank you!

@lgoettgens lgoettgens deleted the lg/stale-weakdeps branch June 5, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't report dependencies as stale if they are also in [weakdeps] (in Julia 1.9)
2 participants