Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of Product #1590

Merged
merged 4 commits into from
Jul 23, 2022
Merged

Fix deprecation of Product #1590

merged 4 commits into from
Jul 23, 2022

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Jul 11, 2022

Fixes #1589.

With this PR (and julia --depwarn=yes):

julia> product_distribution(fill(Weibull(), 5))
Product{Continuous, Weibull{Float64}, Vector{Weibull{Float64}}}(v=Weibull{Float64}[Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0)])

julia> Product(fill(Weibull(), 5))
┌ Warning: Product(v) is deprecated, please use product_distribution(v)
│   caller = top-level scope at REPL[5]:1
└ @ Core REPL[5]:1
Product{Continuous, Weibull{Float64}, Vector{Weibull{Float64}}}(v=Weibull{Float64}[Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0), Weibull{Float64}=1.0, θ=1.0)])

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #1590 (4a045be) into master (c664d78) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1590   +/-   ##
=======================================
  Coverage   85.73%   85.74%           
=======================================
  Files         129      129           
  Lines        7971     7975    +4     
=======================================
+ Hits         6834     6838    +4     
  Misses       1137     1137           
Impacted Files Coverage Δ
src/multivariate/product.jl 100.00% <100.00%> (ø)
src/product.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c664d78...4a045be. Read the comment docs.

@devmotion devmotion merged commit 7c3af32 into master Jul 23, 2022
@oschulz
Copy link
Contributor

oschulz commented Jul 23, 2022

Thanks!

@devmotion devmotion deleted the dw/fix_deprecations branch July 23, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

product_distribution deprecated?
3 participants