Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CGDFG infinite recursion on deleteFactor #809

Closed
GearsAD opened this issue Oct 17, 2021 · 3 comments
Closed

CGDFG infinite recursion on deleteFactor #809

GearsAD opened this issue Oct 17, 2021 · 3 comments
Labels
bug Something isn't working
Milestone
v0.16.2

Comments

@GearsAD
Copy link
Collaborator

GearsAD commented Oct 17, 2021

The IIF current solver behavior replaces factors during rebuildFactorMetadata. This is an issue with CGDFG because deleting factors retrieves the factor. To fix this we should introduce a flag to suppress the getFactor call in deleteFactor, which is only used by IIF during rebuildFactorMetadata.
@GearsAD GearsAD mentioned this issue Oct 17, 2021
Merged
@dehann
Copy link
Member

dehann commented Oct 17, 2021

xref JuliaRobotics/IncrementalInference.jl#1424

@dehann dehann added this to the v0.16.2 milestone Oct 17, 2021
@dehann dehann added the bug Something isn't working label Oct 17, 2021
@dehann
Copy link
Member

dehann commented Oct 17, 2021

think we can close this and resolve the DFGVariable[] IIIF 1424 issue over there?

@dehann dehann mentioned this issue Oct 17, 2021
Merged
@GearsAD
Copy link
Collaborator Author

GearsAD commented Jan 9, 2022

Yep, merging

@GearsAD GearsAD closed this as completed Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.16.2
Development

No branches or pull requests
2 participants
@dehann @GearsAD