Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switching to default JLL-provided binary #661

Closed
sloede opened this issue Oct 3, 2022 · 3 comments · Fixed by #662
Closed

Switching to default JLL-provided binary #661

sloede opened this issue Oct 3, 2022 · 3 comments · Fixed by #662

Comments

@sloede
Copy link
Member

sloede commented Oct 3, 2022

As far as I can tell, MPIPreferences.use_jll_binary requires to manually specify the desired JLL binary to use. IIRC, setting JULIA_MPI_BINARY="" (to the empty string) automatically selected the default JLL binary. This was convenient if you just wanted to restore MPI.jl to "factory defaults". Would it be possible to bring this back, i.e., a MPIPreferences.use_jll_binary method without the binary argument that then selects the default depending on the OS?

@giordano
Copy link
Member

giordano commented Oct 3, 2022

function use_jll_binary(binary = Sys.iswindows() ? "MicrosoftMPI_jll" : "MPICH_jll"; export_prefs=false, force=true)

It's already the case? Also, the docstring says

  • "MicrosoftMPI_jll" (Only option and default on Winddows)
  • "MPICH_jll" (Default on all other platform)

@sloede
Copy link
Member Author

sloede commented Oct 3, 2022

Ah, then I got confused by the docstring. Can we maybe change

MPIPreferences.use_jll_binary(binary; export_prefs=false, force=true)

to something like

"""
    MPIPreferences.use_jll_binary([binary]; export_prefs=false, force=true)
...
"""

?

@giordano
Copy link
Member

giordano commented Oct 3, 2022

Sounds good with me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants