-
-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
versioning MPIPreferences metadata #642
Comments
That's a good idea, but I'm not sure how to best do that. A |
I assume this is to allow storing separate preferences for different versions of MPIPreferences? I would just store all of your preferences inside of a dictionary that is keyed by the package's version number; or maybe keyed by the major and minor parts, so patch releases all share the same settings. |
No, that wasn't my intention. It was more trying to think about compatibility: if we need to change what we store (add more additional keys, change the values certain keys accept), what would be the best way to do this? If the preferences are stored in a given project, then this is simply determined by the compat restrictions on MPIPreferences.jl, and so it isn't really a problem. But since we allow preferences to be inherited from the environment stack, we could end up with the case where the preferences which are loaded are from an older or newer version of MPIPreferences than that used in the current project. My current idea was to add a |
I like the idea of a format key. We don't want to version the settings but we want to warn if someone loads settings that are incompatible. |
We should probably add some mechanism to version the MPIPreferences metadata. The obvious way is to add a version and/or format key (similar to those in the Manifest.toml).
@giordano @vchuravy any suggestions on how best to do this?
The text was updated successfully, but these errors were encountered: