Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

length of MPIBuffertype{T} #287

Closed
kose-y opened this issue Jul 12, 2019 · 0 comments
Closed

length of MPIBuffertype{T} #287

kose-y opened this issue Jul 12, 2019 · 0 comments

Comments

@kose-y
Copy link
Contributor

kose-y commented Jul 12, 2019

Related to #283.

Some functions with the argument of type MPIBuffertype{T} use length of it, but usage of length this way is only valid for AbstractArray{T} input. In particular, Ptr{T} argument would always return 1 as its length, and this may cause unexpected behaviors.

Found in:

Reduce!(sendbuf, recvbuf, length(sendbuf), op, root, comm)

Allreduce!(sendbuf, recvbuf, length(recvbuf), op, comm)

Allreduce!(MPI.IN_PLACE, buf, length(buf), op, comm)

Allreduce!(sendbuf, recvbuf, length(recvbuf), op, comm)

These will/may be fixed with #286, as most of the MPI calls will be modified with it anyway. (It already contains a modification for the first one, and is likely to have modification for the other ones)

@kose-y
Copy link
Contributor Author

kose-y commented Aug 15, 2019

resolved with #302.

@kose-y kose-y closed this as completed Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant