Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade NetCDF to 4.8.1 #3620

Merged
merged 2 commits into from
Oct 12, 2021
Merged

Conversation

Alexander-Barth
Copy link
Contributor

This PR upgraded NetCDF to 4.8.1 from 4.7.4..

I had this error described here but changing the Dependency with respect to HDF5_jll as shown in the PR seemed to resolved this issue.

I kept the version_offset unchanged, but maybe they need to be reset to v"0.0.0"?

@vchuravy vchuravy requested a review from giordano September 29, 2021 22:24
@giordano
Copy link
Member

I kept the version_offset unchanged, but maybe they need to be reset to v"0.0.0"?

No, they can stay the same here: you're bumping the upstream version and the offset are only to distinguish the build for v1.3 and v1.6+. However you do need to do some edits to the build_tarballs.jl files, here you aren't actually building anyhing.

@Alexander-Barth
Copy link
Contributor Author

Alexander-Barth commented Oct 11, 2021

Thank you for having a look.
I just rechecked on my end. Here a julia --color=yes ./build_tarballs.jl --verbose creates the following files:

cd ~/src/Yggdrasil/N/NetCDF/
$ ls -l */products/
[email protected]/products/:
insgesamt 3164
-rw-r--r-- 1 abarth abarth 597819 Okt 11 22:45 NetCDF.v400.801.100.aarch64-linux-gnu.tar.gz
-rw-r--r-- 1 abarth abarth 637229 Okt 11 22:46 NetCDF.v400.801.100.i686-w64-mingw32.tar.gz
-rw-r--r-- 1 abarth abarth 625068 Okt 11 22:46 NetCDF.v400.801.100.x86_64-apple-darwin.tar.gz
-rw-r--r-- 1 abarth abarth 667070 Okt 11 22:47 NetCDF.v400.801.100.x86_64-linux-gnu.tar.gz
-rw-r--r-- 1 abarth abarth 707494 Okt 11 22:47 NetCDF.v400.801.100.x86_64-w64-mingw32.tar.gz

[email protected]/products/:
insgesamt 3164
-rw-r--r-- 1 abarth abarth 597930 Okt 11 22:44 NetCDF.v400.802.100.aarch64-linux-gnu.tar.gz
-rw-r--r-- 1 abarth abarth 637217 Okt 11 22:44 NetCDF.v400.802.100.i686-w64-mingw32.tar.gz
-rw-r--r-- 1 abarth abarth 625380 Okt 11 22:45 NetCDF.v400.802.100.x86_64-apple-darwin.tar.gz
-rw-r--r-- 1 abarth abarth 667239 Okt 11 22:45 NetCDF.v400.802.100.x86_64-linux-gnu.tar.gz
-rw-r--r-- 1 abarth abarth 707482 Okt 11 22:46 NetCDF.v400.802.100.x86_64-w64-mingw32.tar.gz

Can you give me some more information about what needs to be changed in build_tarballs.jl ?
Thanks a lot for your help!

@giordano
Copy link
Member

Can you some more information about what needs to be changed in build_tarballs.jl ?

Anything, you need to touch the file somehow. Add a newline somewhere, for example

@Alexander-Barth
Copy link
Contributor Author

Thanks! I just added a new line to build_tarballs.jl. I think it worked now.

@giordano giordano merged commit 453fb46 into JuliaPackaging:master Oct 12, 2021
@giordano giordano removed their request for review October 12, 2021 09:39
felixcremer added a commit to felixcremer/Yggdrasil that referenced this pull request Feb 22, 2022
giordano added a commit that referenced this pull request Feb 22, 2022
* Revert "Upgrade NetCDF to 4.8.1 (#3620)"

This reverts commit 453fb46.

* [NetCDF] Build NetCDF for Julia v1.6+ instead of v1.3

Co-authored-by: Mosè Giordano <[email protected]>
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
* upgrade NetCDF to 4.8.1

* [NetCDF] Touch build_tarballs.jl to trigger a rebuild
simeonschaub pushed a commit to simeonschaub/Yggdrasil that referenced this pull request Feb 23, 2022
…ing#4481)

* Revert "Upgrade NetCDF to 4.8.1 (JuliaPackaging#3620)"

This reverts commit 453fb46.

* [NetCDF] Build NetCDF for Julia v1.6+ instead of v1.3

Co-authored-by: Mosè Giordano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants