-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade NetCDF to 4.8.1 #3620
Upgrade NetCDF to 4.8.1 #3620
Conversation
No, they can stay the same here: you're bumping the upstream version and the offset are only to distinguish the build for v1.3 and v1.6+. However you do need to do some edits to the |
Thank you for having a look.
Can you give me some more information about what needs to be changed in |
Anything, you need to touch the file somehow. Add a newline somewhere, for example |
Thanks! I just added a new line to |
This reverts commit 453fb46.
* Revert "Upgrade NetCDF to 4.8.1 (#3620)" This reverts commit 453fb46. * [NetCDF] Build NetCDF for Julia v1.6+ instead of v1.3 Co-authored-by: Mosè Giordano <[email protected]>
* upgrade NetCDF to 4.8.1 * [NetCDF] Touch build_tarballs.jl to trigger a rebuild
…ing#4481) * Revert "Upgrade NetCDF to 4.8.1 (JuliaPackaging#3620)" This reverts commit 453fb46. * [NetCDF] Build NetCDF for Julia v1.6+ instead of v1.3 Co-authored-by: Mosè Giordano <[email protected]>
This PR upgraded NetCDF to 4.8.1 from 4.7.4..
I had this error described here but changing the
Dependency
with respect toHDF5_jll
as shown in the PR seemed to resolved this issue.I kept the
version_offset
unchanged, but maybe they need to be reset to v"0.0.0"?