-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Auditor] Remove libtool *.la files #1105
[Auditor] Remove libtool *.la files #1105
Conversation
To do this it may be easier to move this to a function in the A question is: should we have (yet another, sigh) flag to disable this pass if necessary? Audit passes have to be reworked in a saner way, but that's #670. |
I am going to add an autotools build system to |
5d0b121
to
1202c5f
Compare
fda46fe
to
216908b
Compare
19b1f1f
to
0bffd96
Compare
I don't really think we need a flag to disable this. We already make sure to not delete files that have extension .la but are not libtool files. And there simply are no legitimate applications of an installed *.la file anymore. Even Autotools Mythbuster agrees: "their presence on most modern systems is vestigial at best". It has a fringe application for static linking (but we don't care about that), and nothing else. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thanks! Only a request about one more test.
0bffd96
to
8bbcbb8
Compare
8bbcbb8
to
fd2e7ba
Compare
Resolves #1104 (or at least will, once it is complete)
TODO: