Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditor] Remove libtool *.la files #1105

Merged
merged 2 commits into from
Oct 21, 2021

Conversation

fingolfin
Copy link
Member

Resolves #1104 (or at least will, once it is complete)

TODO:

  • add a test (or in general: properly test it)
  • document it (where?)
  • perhaps the Julia code to another place?

@giordano
Copy link
Member

add a test (or in general: properly test it)

To do this it may be easier to move this to a function in the auditor/ directory and add a test for that function only.

A question is: should we have (yet another, sigh) flag to disable this pass if necessary? Audit passes have to be reworked in a saner way, but that's #670.

@fingolfin
Copy link
Member Author

I am going to add an autotools build system to libfoo, then testing this feature is a trivial consequence.

@fingolfin fingolfin force-pushed the mh/remove-libtool-la-files branch 4 times, most recently from 5d0b121 to 1202c5f Compare October 19, 2021 20:45
@fingolfin fingolfin force-pushed the mh/remove-libtool-la-files branch from fda46fe to 216908b Compare October 19, 2021 23:44
@fingolfin fingolfin force-pushed the mh/remove-libtool-la-files branch 3 times, most recently from 19b1f1f to 0bffd96 Compare October 20, 2021 00:58
@fingolfin fingolfin marked this pull request as ready for review October 20, 2021 00:58
@fingolfin
Copy link
Member Author

I don't really think we need a flag to disable this. We already make sure to not delete files that have extension .la but are not libtool files. And there simply are no legitimate applications of an installed *.la file anymore. Even Autotools Mythbuster agrees: "their presence on most modern systems is vestigial at best". It has a fringe application for static linking (but we don't care about that), and nothing else.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, thanks! Only a request about one more test.

@fingolfin fingolfin force-pushed the mh/remove-libtool-la-files branch from 0bffd96 to 8bbcbb8 Compare October 21, 2021 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Audit] Add a pass to remove libtool archives
2 participants