Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIR Particle filter misnamed? #22

Closed
zsunberg opened this issue Jan 15, 2019 · 1 comment · Fixed by #44
Closed

SIR Particle filter misnamed? #22

zsunberg opened this issue Jan 15, 2019 · 1 comment · Fixed by #44

Comments

@zsunberg
Copy link
Member

It seems that I may have misunderstood what is commonly meant by "SIR Particle Filter". It seems that most authors use SIR to refer to filters that use any proposal distribution while the SIRParticleFilter in this package always uses the transition probability distribution as the proposal distribution.

Perhaps BootstrapFilter would be better? It's hard to tell what people use.

Relevant sources to consult:

@zsunberg zsunberg changed the title SIR Particle filter misnamed SIR Particle filter misnamed? Jan 15, 2019
@zsunberg
Copy link
Member Author

We should also check what Thrun calls it in Probabilistic Robotics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant