Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect interface type for LAPACK #35

Closed
ViralBShah opened this issue Mar 27, 2021 · 11 comments
Closed

Detect interface type for LAPACK #35

ViralBShah opened this issue Mar 27, 2021 · 11 comments
Labels
enhancement New feature or request

Comments

@ViralBShah
Copy link
Collaborator

ViralBShah commented Mar 27, 2021 •
edited
Loading

This is using the LAPACK that is registered in Yggdrasil. I suppose we only have a BLAS test for detecting the interface type, and we should probably do it with an LAPACK function as well.

We need to do this so that we can load BLAS and LAPACK separately (as the case will be if we use a BLIS provided BLAS). Currently we have only tested OpenBLAS and MKL, both of which ship both BLAS and LAPACK.

julia> using LAPACK_jll

julia> BLAS.lbt_forward(LAPACK_jll.liblapack)
Error: no BLAS/LAPACK library loaded!
Unable to autodetect interface type of "/Users/viral/.julia/artifacts/db87d23fe12e550a2852beb75a9814b73fc91424/lib/liblapack.3.9.0.dylib"
0
@ViralBShah
Copy link
Collaborator Author

ViralBShah commented Jan 7, 2022 •
edited
Loading

We probably need to fix this so that we can use Accelerate on macOS, essential for M1.

@ViralBShah
Copy link
Collaborator Author

ViralBShah commented Aug 7, 2022 •
edited
Loading

Here's on MacOS with BLAS forwards for Accelerate:

julia> BLAS.lbt_forward(LAPACK_jll.liblapack, clear=false, verbose=true)
Generating forwards to /Users/viral/.julia/artifacts/54d54e7b7749e3e8c5af5ad9c346325220c9d553/lib/liblapack.3.10.0.dylib
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
Unable to autodetect complex return style of "/Users/viral/.julia/artifacts/54d54e7b7749e3e8c5af5ad9c346325220c9d553/lib/liblapack.3.10.0.dylib"
0

Will Apple BLAS + Yggdrasil built LAPACK work together? cc @giordano @staticfloat

@ViralBShah ViralBShah changed the title Unable to detect interface type for LAPACK Detect interface type for LAPACK Aug 7, 2022
@ViralBShah ViralBShah mentioned this issue Aug 7, 2022
Closed
@ViralBShah ViralBShah added the enhancement New feature or request label Aug 7, 2022
@staticfloat
Copy link
Member

staticfloat commented Aug 8, 2022 •
edited
Loading

You need to load Apple Accelerate first:

On Apple Silicon (which has no complex return style problems)

julia> using LinearAlgebra, LAPACK_jll
       BLAS.lbt_forward("/System/Library/Frameworks/Accelerate.framework/Accelerate"; verbose=true, clear=true)
       BLAS.lbt_forward(LAPACK_jll.liblapack_path; verbose=true)
Generating forwards to /System/Library/Frameworks/Accelerate.framework/Accelerate
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
Processed 4945 symbols; forwarded 1705 symbols with 32-bit interface and mangling to a suffix of ""
Generating forwards to /Users/sabae/.julia/artifacts/65c65bc8413bbca96d1d988b65cdae3d9a64cedb/lib/liblapack.3.10.0.dylib
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
Processed 4945 symbols; forwarded 4945 symbols with 32-bit interface and mangling to a suffix of ""
4945

On x86_64 (which does have complex return style problems)

julia> using LinearAlgebra, LAPACK_jll
       BLAS.lbt_forward("/System/Library/Frameworks/Accelerate.framework/Accelerate"; verbose=true, clear=true)
       BLAS.lbt_forward(LAPACK_jll.liblapack_path; verbose=true)
Generating forwards to /System/Library/Frameworks/Accelerate.framework/Accelerate
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
 -> Autodetected f2c-style calling convention
 - [2732] f2c(cdotc_)
 - [2733] f2c(cdotu_)
 - [3856] f2c(sasum_)
 - [3872] f2c(scasum_)
 - [3873] f2c(scnrm2_)
 - [3879] f2c(sdot_)
 - [3880] f2c(sdsdot_)
 - [4026] f2c(slamc3_)
 - [4027] f2c(slamch_)
 - [4153] f2c(snrm2_)
 - [4436] f2c(zdotc_)
 - [4437] f2c(zdotu_)
Processed 4945 symbols; forwarded 1705 symbols with 32-bit interface and mangling to a suffix of ""
Generating forwards to /Users/julia/.julia/artifacts/054602666af60d1f1b093c1edcf466c7f86e6d8f/lib/liblapack.3.9.0.dylib
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
 -> Autodetected gfortran calling convention
Processed 4945 symbols; forwarded 4945 symbols with 32-bit interface and mangling to a suffix of ""
4945

@ViralBShah
Copy link
Collaborator Author

Is it possible that LAPACK on the same platform (arm macos) has different settings (on complex return type and such) than what Apple ships in Accelerate?

@ViralBShah
Copy link
Collaborator Author

Doesn't work for me.

               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.9.0-DEV.1094 (2022-08-07)
 _/ |\__'_|_|_|\__'_|  |  vs/sparsesysimage/70f74fe60d (fork: 1 commits, 0 days)
|__/                   |

julia> using LinearAlgebra, LAPACK_jll

julia> BLAS.lbt_forward("/System/Library/Frameworks/Accelerate.framework/Accelerate"; verbose=true, clear=true)
Generating forwards to /System/Library/Frameworks/Accelerate.framework/Accelerate
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
 -> Autodetected argument-passing complex return style
 -> Autodetected f2c-style calling convention
 - [2732] complex(cdotc_)
 - [2732] f2c(cdotc_)
 - [2733] complex(cdotu_)
 - [2733] f2c(cdotu_)
 - [3856] f2c(sasum_)
 - [3872] f2c(scasum_)
 - [3873] f2c(scnrm2_)
 - [3879] f2c(sdot_)
 - [3880] f2c(sdsdot_)
 - [4026] f2c(slamc3_)
 - [4027] f2c(slamch_)
 - [4153] f2c(snrm2_)
 - [4436] complex(zdotc_)
 - [4436] f2c(zdotc_)
 - [4437] complex(zdotu_)
 - [4437] f2c(zdotu_)
Processed 4945 symbols; forwarded 1705 symbols with 32-bit interface and mangling to a suffix of ""
1705

julia> BLAS.lbt_forward(LAPACK_jll.liblapack_path; verbose=true)
Generating forwards to /Users/viral/.julia/artifacts/54d54e7b7749e3e8c5af5ad9c346325220c9d553/lib/liblapack.3.10.0.dylib
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
Unable to autodetect complex return style of "/Users/viral/.julia/artifacts/54d54e7b7749e3e8c5af5ad9c346325220c9d553/lib/liblapack.3.10.0.dylib"
0

@ViralBShah
Copy link
Collaborator Author

With JuliaLang/julia#82 this works. Is it a problem that the different libraries (BLAS From Accelerate and LAPACK from Ygg) have different fortran calling conventions and different complex return style?

julia> BLAS.lbt_forward("/System/Library/Frameworks/Accelerate.framework/Accelerate"; verbose=true, clear=true)
Generating forwards to /System/Library/Frameworks/Accelerate.framework/Accelerate
-> Autodetected symbol suffix ""
-> Autodetected interface LP64 (32-bit)
-> Autodetected argument-passing complex return style
-> Autodetected f2c-style calling convention
- [2732] complex(cdotc_)
- [2732] f2c(cdotc_)
- [2733] complex(cdotu_)
- [2733] f2c(cdotu_)
julia> BLAS.lbt_forward(LAPACK_jll.liblapack_path; verbose=true)
Generating forwards to /Users/viral/.julia/artifacts/54d54e7b7749e3e8c5af5ad9c346325220c9d553/lib/liblapack.3.10.0.dylib
 -> Autodetected symbol suffix ""
 -> Autodetected interface LP64 (32-bit)
 -> Autodetected normal complex return style
 -> Autodetected gfortran calling convention
Processed 4945 symbols; forwarded 4945 symbols with 32-bit interface and mangling to a suffix of ""

@ViralBShah
Copy link
Collaborator Author

ViralBShah commented Aug 8, 2022 •
edited
Loading

Doesn't seem to work though. Just after doing the BLAS forwards to Accelerate, and trying to run peakflops:

Processed 4945 symbols; forwarded 1705 symbols with 32-bit interface and mangling to a suffix of ""
1705

julia> peakflops()
Error: no BLAS/LAPACK library loaded!
Error: no BLAS/LAPACK library loaded!
ERROR: AssertionError: a2[1, 1] == n

@staticfloat
Copy link
Member

Is it a problem that the different libraries (BLAS From Accelerate and LAPACK from Ygg) have different fortran calling conventions and different complex return style?

I don't think it should be a problem, as Accelerate should call its own symbols internally. We expose a "gfortran" calling convention and "normal" complex return style, so LBT will automatically translate Accelerate to conform to that, allowing LAPACK to call Accelerate without problems. If we had a library that called into LBT expecting a non-gfortran calling convention, that would be a problem.

Doesn't seem to work though:

Your Julia is trying to call ILP64 symbols which you cleared out. Julia will never use Accelerate, since Accelerate is LP64-only. You would need to build Julia to use LP64 instead.

@ViralBShah
Copy link
Collaborator Author

ViralBShah commented Aug 8, 2022 •
edited
Loading

I see - with MKL, we have ILP64, and we just forward the symbols. I suppose if we had a solution to JuliaLang/LinearAlgebra.jl#891, we could use Accelerate seamlessly. Otherwise, it is unlikely we will.

@ViralBShah
Copy link
Collaborator Author

ViralBShah commented Aug 8, 2022 •
edited
Loading

@perrutquist I guess this is where SetBlasInt.jl could come in handy. In theory, we now have a full LP64 Accelerate BLAS + LAPACK that we can use through SetBlasInt on the mac. It's all a bit of a hack, but should probably work.

@ViralBShah
Copy link
Collaborator Author

I think we are ok without this. The original reason was Apple's BLAS, but we have ILP64 on macOS now: https://discourse.julialang.org/t/appleaccelerate-jl-v0-4-0/99351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@staticfloat @ViralBShah