Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to manually modify PATH #935

Closed
adrhill opened this issue May 28, 2024 · 4 comments
Closed

Allow users to manually modify PATH #935

adrhill opened this issue May 28, 2024 · 4 comments

Comments

@adrhill
Copy link

adrhill commented May 28, 2024

Problem

On many systems, having programs like juliaup modify the PATH in a .bash_profile or .zshrc config file is not a viable option.

Immutable or unreadable configuration files are the source of many crash reports, e.g. the "Failed to open file" error (#826, #864, #874, #891, #918, ...).

In #796, @davidanthoff mentioned

So in both cases it looks like we don't have the permissions required to edit the shell scripts where add Juliaup to the PATH. We can (and should) obviously catch this and output something more helpful, but at the same time I'm not sure how we can recover from this error, putting things onto the PATH is really crucial for things to work, but if we can't do that, then that is kind of a problem...

If anyone has an idea, that would be great :)

Feature request

juliaup should provide an option for advanced users where it simply tells them what needs to be manually added to their PATH.

Such an option seemingly exists, but doesn't appear to work (#875), still running into the "Failed to open file" error:

✔ Do you want to add the Julia binaries to your PATH by manipulating various shell startup scripts? · no

This has also been observed in #920:

Strangely, the crash during the juliaup installation also occurs if I customize the installation to decline "Do you want to add the Julia binaries to your PATH by manipulating various shell startup scripts?".

Related discussions: #796, #920, #875

@tecosaur
Copy link
Contributor

tecosaur commented May 30, 2024

This should be helped/partially solved by #844, but I think that conversation got a bit side-tracked (talking about XDG compliance in Julia itself, again 🤦).

@adrhill
Copy link
Author

adrhill commented May 30, 2024

Even with #844 addressed, I still find it surprising that the "manual installation option" tries to open any shell config files. Maybe this is a bug?

@davidanthoff
Copy link
Collaborator

Yes, that is a bug, fix is coming with #943.

That is only the first part to the broader problem, next I need to output better error messages when these files are not editable and give some instructions on what to do.

@adrhill
Copy link
Author

adrhill commented Jun 4, 2024

Closed by #943.

@adrhill adrhill closed this as completed Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants