-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update libuv to v2-1.48.0 #49937
update libuv to v2-1.48.0 #49937
Conversation
Julia is still using the blocking variant of filesystem read and write calls (cf. code) which has dramatic impact on performance because during the IO:
Libuv replaced its thread pool solution with May I know why Julia is still using this blocking file IO model that is inherently against its own task model? |
It is the latter |
How about this: once this PR is merged and we have io_uring backed for non-blocking filesystem IO, I open a PR to use non-blocking file IO on Linux only? This is a clear winner path for all and has less friction than a solution based on libuv threadpool. |
Elliot asked this updates NEWS to mention the updated platform support |
fc8964a
to
5093cb1
Compare
Builds are going through! What a painless upgrade. |
@vtjnash we looked into this on the CI-dev call today, and we noticed that Windows is now failing this part of the Running this branch's build locally on a Windows VM, I am able to see that the following works on Julia v1.9.1: touch("𝕃pt2")
rm("𝕃pt2") But it breaks with
As a fun side note, if you use the |
Yeah, that is fixed in libuv, but I haven't pushed a new version with it yet |
more changes:
|
We should also now unconditionally add the |
f0136aa
to
daa1e76
Compare
6926d0e
to
ea3dd08
Compare
Fix a test bug introduced in 7f507e6 resulting in this file being disabled on Windows
This broke FreeBSD CI
|
#49937 optimistically enabled some file watcher tests on FreeBSD due to changes made in libuv that suggested it should work, but unfortunately it does not.
Notable additions:
Closes #47611
Fixes #33486