Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build broken on macOS: implicit declaration of function 'jl_profile_is_buffer_full' is invalid in C99 #38331

Closed
iamed2 opened this issue Nov 6, 2020 · 2 comments

Comments

@iamed2
Copy link
Contributor

iamed2 commented Nov 6, 2020

In file included from /Users/ericdavies/repos/juliamaster/src/signal-handling.c:120:
In file included from ./signals-unix.c:228:
./signals-mach.c:496:17: error: implicit declaration of function 'jl_profile_is_buffer_full' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
            if (jl_profile_is_buffer_full()) {
                ^
In file included from /Users/ericdavies/repos/juliamaster/src/signal-handling.c:120:
./signals-unix.c:695:21: error: implicit declaration of function 'jl_profile_is_buffer_full' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
                if (jl_profile_is_buffer_full()) {

Introduced by: #36006

@kimikage
Copy link
Contributor

kimikage commented Nov 6, 2020

I'm sorry for my elementary mistakes.

As the comments added in PR #36006 say, "signals-*.c" are #included. That confuses me and my linter a lot. 🍇

@fredrikekre
Copy link
Member

#38332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants