Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

excise ext/* #118

Closed
vchuravy opened this issue Feb 8, 2018 · 5 comments
Closed

excise ext/* #118

vchuravy opened this issue Feb 8, 2018 · 5 comments

Comments

@vchuravy
Copy link
Member

vchuravy commented Feb 8, 2018

It would be great if we could excise the copied dependencies in ext/*,
which is needed by JuliaLang/julia#25714

Probably moving TOML to JuliaLang would be sensible and for the rest we should be able to use upstream.

@KristofferC
Copy link
Member

KristofferC commented Feb 8, 2018

We only need a little bit from BinaryProvider (one file) so that could probably be seen as an implementation detail. For TOML, we could make it an stdlib or keep it as ext.

@bicycle1885
Copy link
Member

bicycle1885 commented Apr 2, 2018

Just in case you're interested, I wrote a TOML parser that is v0.4.0 compatible (as far as I'm aware of) this weekend. It is still in alpha quality, but may be useful for Pkg3.jl in the future. The code is here: https://github.com/bicycle1885/TOML.jl.

@KristofferC
Copy link
Member

KristofferC commented Apr 2, 2018

It would be nice to be able to use the 0.4.0 functionalities in TOML. A benchmark to compare with could be #116.

I tried it but it seems to fail at key = "string". key = 'string' works.

@StefanKarpinski
Copy link
Member

I'd really like to have a TOML parser that let's me pull out specific values and generates a custom state machine that can scan through extracting those values at maximal speed. Essentially something that can generate the kinds of methods I've written in base/loading.jl to do this with regular expressions:

https://github.com/JuliaLang/julia/blob/c4c93ea692e9972a97a3f7149d79c92ad5d8106d/base/loading.jl#L480-L510

That's a fairly involved project, however, but it would be generally useful.

@00vareladavid
Copy link
Contributor

Closing in favor of #1011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants