-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fractional percentage notation in color parser #431
Comments
Julia v1.5 will be released soon, so I'd like to "cancel" the deprecation warning. Lines 143 to 147 in 53c2acb
Instead, in Colors v0.13 I'll add a deprecation warning to: Line 212 in 53c2acb
(cf. #406 (comment)) |
So by "cancel," do you mean "turn the warning into an error" or something else? I agree with adding a depwarn to that method in Colors. But there's no conservation of depwarns, you can have as many as you want 😄. |
Yes. I think FixedPointNumbers/ColorTypes/ColorVectorSpace are starting to move towards the next minor (not patch) level updates. I'm just trying to enumerate the (trivial) fixes to piggyback on the update. |
The color parser has only accepted integer percentages since Color.jl was separated from Compose.jl.(cf. 6738401)
This is practical enough as long as the users write the percentages with
@colorant_str
. So I added the specification to the document in PR #406.However, other programs may generate a fractional decimal percentage.For example, https://github.com/JuliaLang/julia-logo-graphics/blame/168fb6c1164e341df360ed6ced519e1e0cb7de3a/images/julia-logo-color.svg.
I do never intend to make the parser fully CSS compliant, but I'd like to remove the restriction.
The text was updated successfully, but these errors were encountered: