Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search filter toggle buttons have broken UI [regression] #2406

Closed
LilithHafner opened this issue Jan 19, 2024 · 3 comments · Fixed by #2408
Closed

Search filter toggle buttons have broken UI [regression] #2406

LilithHafner opened this issue Jan 19, 2024 · 3 comments · Fixed by #2408
Labels
Format: HTML Related to the default HTML output Type: Bugfix

Comments

@LilithHafner
Copy link
Contributor

The "Filters" toggle buttons' state is no longer visible in the UI.

Screenshot from 2024-01-19 10-22-41

After clicking some of the buttons a bunch I got this search result, with no indication of how I can get back to a normal result.

New UI introduced in #2202 cc @Hetarth02. The UI looks fine in the PR demo, but now it seems broken on docs.julialang.org on both IceCat and Chromium.

@Hetarth02
Copy link
Contributor

Hetarth02 commented Jan 19, 2024

Does julialang's docs introduce some custom css?

I think it may be due to that. Also, can you confirm if this also happens in the light mode as well or not?

Edit: I think there might have been some changes(cc @mortenpi ) in the css files for dark theme in between. I have confirmed that the filter state indicators are working fine in the light mode.(cc @LilithHafner )

Edit: I have found the issue, hopefully it resolves the bug.

@LilithHafner
Copy link
Contributor Author

can you confirm if this also happens in the light mode as well or not?

Can confirm it works for me in light mode.

@Hetarth02
Copy link
Contributor

Did a PR which fixes this in dark mode as well.

@mortenpi mortenpi added Format: HTML Related to the default HTML output Type: Bugfix labels Jan 22, 2024
@mortenpi mortenpi linked a pull request Jan 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Bugfix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants