Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML footnotes end up in text instead of at the end #1104

Closed
tpapp opened this issue Aug 20, 2019 · 6 comments
Closed

HTML footnotes end up in text instead of at the end #1104

tpapp opened this issue Aug 20, 2019 · 6 comments
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Milestone

Comments

@tpapp
Copy link
Contributor

tpapp commented Aug 20, 2019

In this generated documentation:

https://tamaspapp.eu/DynamicHMC.jl/latest/

Generated from sources like:

https://github.com/tpapp/DynamicHMC.jl/blob/master/docs/src/index.md

With a makedocs script at

https://github.com/tpapp/DynamicHMC.jl/blob/master/docs/make.jl

using Documenter 0.23, the footnotes end up where written, instead of at the end of the HTML page.

@tpapp
Copy link
Contributor Author

tpapp commented Aug 20, 2019

Same with Documenter 0.22.6.

@tpapp
Copy link
Contributor Author

tpapp commented Aug 20, 2019

But current master, ie

  [e30172f5] Documenter v0.23.2 #master (https://github.com/JuliaDocs/Documenter.jl.git)

works fine.

@mortenpi mortenpi added this to the 0.24.0 milestone Aug 20, 2019
@mortenpi
Copy link
Member

Yeah, I changed this in #1043. So nothing else to really do here?

@mortenpi mortenpi added the Format: HTML Related to the default HTML output label Aug 20, 2019
@tpapp
Copy link
Contributor Author

tpapp commented Aug 20, 2019

It would be great to have a release with that fix if that's feasible.

@mortenpi
Copy link
Member

This will be in 0.24.0. The change is not really easily backportable (and is not a bugfix). I hope to tag it next week, but I can't quite promise it -- it's a pretty big release. But I will definitely try to have the release out within the next few weeks.

I'll close this issue as the change has already been implemented on master.

@mortenpi
Copy link
Member

For DynamicHMC though -- you can always have a docs/Manifest.toml and pin Documenter to master there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Format: HTML Related to the default HTML output Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants