check whitespace as part of CI?

[simeonschaub]

I think we should have a job that checks for trailing whitespace and newlines at the end of files. It's not a huge deal, but I encounter that quite often in our code base and it can make diffs a bit more confusing to read since some editors correct this automatically.
Might also make sense to check for correct unicode normalization as well, I think we had some problems with that in the past.

[mcabbott]

For spaces at least, one other possibility would be to check in a .editorconfig file, which most people's editors will obey.

[oxinabox]

Might also make sense to check for correct unicode normalization as well, I think we had some problems with that in the past.

Yeah, it is something like julia compilation gives one form,
but sometimes copy-pasting through different editors gives a different form

[oxinabox]

We might just want to apply the total formatting solution that makes code-suggestions to follow BlueStyle.
I suspect JuliaFormatter will also handle whitespace and newlines at end of file.

[simeonschaub]

For spaces at least, one other possibility would be to check in a .editorconfig file, which most people's editors will obey.

I would probably just do both, making assumptions about people's setups is always dangerous... 😄

[st--]

We might just want to apply the total formatting solution that makes code-suggestions to follow BlueStyle.
I suspect JuliaFormatter will also handle whitespace and newlines at end of file.

Strongly support this. I can confirm that JuliaFormatter does handle whitespace & newlines, and overall including an automatic code formatter makes life SO much easier when dealing with pull requests. Saves a lot of mental effort on both writer & reviewer side that can be put to more effective use:)

You can also add a Github Action that automatically suggests the required formatting changes, see e.g. https://github.com/JuliaGaussianProcesses/AbstractGPs.jl/blob/master/.github/workflows/format.yml

[simeonschaub]

@st-- Do you want to make a PR?

[st--]

@simeonschaub #482