Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clear in docs you may need to unthunk the return from a pullback #154

Open
nickrobinson251 opened this issue Apr 28, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@nickrobinson251
Copy link
Contributor

nickrobinson251 commented Apr 28, 2020

e.g. "things should be unthunked before being passed to pullbacks"

@nickrobinson251 nickrobinson251 transferred this issue from JuliaDiff/ChainRules.jl Apr 28, 2020
@nickrobinson251 nickrobinson251 added the documentation Improvements or additions to documentation label Apr 28, 2020
@nickrobinson251
Copy link
Contributor Author

As mentioned in JuliaDiff/ChainRules.jl#247
the more general "issue" is Thunks can be returned from a pullback
and we should comment on that (and the subsequent need to unthunk)

@nickrobinson251 nickrobinson251 changed the title Make clear in docs "things should be unthunked before being passed to pullbacks" Make clear in docs you may need to unthunk the return from a pullback Aug 20, 2020
@nickrobinson251 nickrobinson251 added the good first issue Good for newcomers label Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant