You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
i.e. because of said rule, we can't concluded that the second order derivative remains zero at type-level. This is unfortunate, because it introduces significant additional code generation. I of course can see both arguments - in general ChainRules has a bit of a type-stability problem because of these types, but I don't think there's any good reason to not return the sentinel type just for these particular functions.
The text was updated successfully, but these errors were encountered:
Yes. I am happy to see it switched back.
We should also switch it back for @scalar_rule that change was motivated by ForwardDiff2.jl but since that's dead, I no longer see such need for it.
I'd like to reconsider the discussion in #187. Because of this change, we have the following unfortunate situation:
vs with that rule set of ZeroTangent:
i.e. because of said rule, we can't concluded that the second order derivative remains zero at type-level. This is unfortunate, because it introduces significant additional code generation. I of course can see both arguments - in general ChainRules has a bit of a type-stability problem because of these types, but I don't think there's any good reason to not return the sentinel type just for these particular functions.
The text was updated successfully, but these errors were encountered: