Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assortment of job-related fixes and improvements #13

Merged
merged 6 commits into from
Jul 17, 2023
Merged

Conversation

mortenpi
Copy link
Member

@mortenpi mortenpi commented Jul 11, 2023

  • name -> alias in submit_job (with a deprecation)

  • extend_job handles 200 success: false responses now

  • The live job tests now print some at-infos, and also set a nice job alias (to make it easier to identify the jobs in the UI).

    image

  • Use @__DIR__ in appbundle live tests.

  • Also update the CHANGELOG and set version to v0.1.3 for tagging.

@mortenpi mortenpi requested a review from pfitzseb July 11, 2023 11:09
@mortenpi mortenpi enabled auto-merge (rebase) July 11, 2023 11:24
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Merging #13 (2485619) into main (a04b368) will decrease coverage by 0.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
- Coverage   76.63%   76.63%   -0.01%     
==========================================
  Files          16       16              
  Lines        2183     2191       +8     
==========================================
+ Hits         1673     1679       +6     
- Misses        510      512       +2     
Impacted Files Coverage Δ
src/jobs/jobs.jl 88.16% <66.66%> (-0.93%) ⬇️
src/jobsubmission.jl 82.18% <100.00%> (+0.26%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

mortenpi added 5 commits July 12, 2023 16:40
The tests now print a helpful at-info when each job gets submitted,
which also includes the job ID, so that the job can be looked up on
JuliaHub. It also sets a user-friendly job alias to all jobs that can be
used to easily find the jobs in the UI.
@mortenpi mortenpi merged commit 8af2ad5 into main Jul 17, 2023
@mortenpi mortenpi deleted the mp/job-tests branch July 17, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants