Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Aqua to tests #411

Closed
gdalle opened this issue Jul 24, 2023 · 3 comments
Closed

Add Aqua to tests #411

gdalle opened this issue Jul 24, 2023 · 3 comments
Labels
Plugin Idea A proposal for a feature that can be accomplished with a plugin

Comments

@gdalle
Copy link
Collaborator

gdalle commented Jul 24, 2023

Aqua.jl is cementing itself as an important tool for testing the quality of a code base.
It would be cool to have an option that generates test/runtests.jl with Aqua built-in, like so:

using Aqua
using MyPackage

@testset verbose = true "MyPackage.jl" begin
    @testset verbose = true "Aqua.jl" begin
        Aqua.test_all(MyPackage)
    end
    # actual tests
end
@nickrobinson251 nickrobinson251 added the Plugin Idea A proposal for a feature that can be accomplished with a plugin label Jul 24, 2023
@gdalle
Copy link
Collaborator Author

gdalle commented Jul 28, 2023

@nickrobinson251 I tried my hand at an easier plugin with #412, but for this one I'd actually need to modify an existing file created by the test plugin instead of creating it from scratch. Any good example I should look at?

@gdalle
Copy link
Collaborator Author

gdalle commented Jul 28, 2023

Crap I also need to modify a whole bunch of TOMLs because it requires Aqua as a test dependency

@gdalle
Copy link
Collaborator Author

gdalle commented Jul 31, 2023

Gonna try to do this by adding an aqua option to the Tests plugin

@gdalle gdalle changed the title Add Aqua plugin? Add Aqua to tests Jul 31, 2023
@gdalle gdalle closed this as completed Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Plugin Idea A proposal for a feature that can be accomplished with a plugin
Projects
None yet
Development

No branches or pull requests

2 participants