Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IdentityOperator does not respect orthogonalities #10

Open
jagot opened this issue Jun 3, 2019 · 0 comments
Open

IdentityOperator does not respect orthogonalities #10

jagot opened this issue Jun 3, 2019 · 0 comments

Comments

@jagot
Copy link
Member

jagot commented Jun 3, 2019

Slightly related to #8. When evaluating the matrix element of IdentityOperator{1} between two configurations, the following occurs:

using EnergyExpressions
import EnergyExpressions: NBodyMatrixElement

a=SlaterDeterminant([:a, :b])
b=SlaterDeterminant([:c, :b])

I₁ = NBodyMatrixElement(a, IdentityOperator{1}(), b, overlap_matrix(a,b))
⟨a|𝐈₁|c⟩

which is obviously wrong, since a and c were not declared as non-orthogonal. It is however not so as to overload iszero for OrbitalMatrixElements of IdentityOperator{N} and require the bra and ket to be equal, since the constituent orbitals may be non-orthogonal. Maybe such OrbitalMatrixElements should be automatically converted to OrbitalOverlaps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant