Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cartesian to OE not working for true anomoly #9

Closed
cadojo opened this issue Sep 23, 2020 · 0 comments · Fixed by #10
Closed

Cartesian to OE not working for true anomoly #9

cadojo opened this issue Sep 23, 2020 · 0 comments · Fixed by #10
Labels
bug Something isn't working

Comments

@cadojo
Copy link
Collaborator

cadojo commented Sep 23, 2020

An incorrect calculation is in CanonicalOrbit(::CartesianOrbit): true anomoly's conditional is incorrect. The condition should check if dot(r_vec, v_vec) > 0.
@cadojo cadojo mentioned this issue Sep 23, 2020
Merged
@cadojo cadojo added the bug Something isn't working label Sep 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Cart2OE transformation function JuliaAstro/GeneralAstrodynamics.jl
1 participant
@cadojo