Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Documentation for using @addlogprob! correctly #206

Closed
itsdfish opened this issue Feb 15, 2024 · 2 comments
Closed

Add Documentation for using @addlogprob! correctly #206

itsdfish opened this issue Feb 15, 2024 · 2 comments

Comments

@itsdfish
Copy link
Contributor

Issue #201 describes a problem with using @addlogprob!. The solution was to wrap it in a conditional:

if DynamicPPL.leafcontext(__context__) !== DynamicPPL.PriorContext() 
       @addlogprob! ....
end

This would be great to add to the documentation.

@nikola-sur
Copy link
Collaborator

Thank you for this comment! This would be very useful to add to the documentation because other users seem to have run into this. Feel free to create a PR or I can set that up later.

@itsdfish
Copy link
Contributor Author

Seems easy enough. I will submit a PR in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants