Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a ! needs to be added inside an object literal, it should convert shorthand to full #50

Closed
JoshuaKGoldberg opened this issue Dec 24, 2018 · 0 comments · Fixed by #407
Closed

When a ! needs to be added inside an object literal, it should convert shorthand to full #50

JoshuaKGoldberg opened this issue Dec 24, 2018 · 0 comments · Fixed by #407
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛

Comments

@JoshuaKGoldberg
Copy link
Owner

If { stat } needs to mark stat with a !, it would need to change it to { stat: stat! }.

Related: microsoft/TypeScript#13035 tracks allowing casting within object literals.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: accepting prs Please, send a pull request to resolve this! 🙏 type: bug Something isn't working :( 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added strict non-null assertion support for object literals JoshuaKGoldberg/TypeStat
1 participant
@JoshuaKGoldberg