fix merge conflict from waitForCompletion feature #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ added error handling function param on a new constructor + added the function param on the static `from` method + caught the errors in the callback method
+ removed `@ts-expect-error line` bc it was throwing error itself
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…31f8f5 (#850) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…bac (#849) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
+ Instead of a new constructor, I added the `errorHandler` on every other constructor + removed the superflous if checks + added `errorHandler` on every `return new CronJob`
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: intcreator <[email protected]>
<!--- Provide a general summary of your changes in the Title above (following the Conventional Commits standard) --> <!-- More infos: https://www.conventionalcommits.org --> <!-- Commit types: https://github.com/insurgent-lab/conventional-changelog-preset#commit-types--> ## Description <!--- Describe your changes in detail --> Add support for Node v22. Keep support for v16 until we release a major version. ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> We want to always support at least the latest 3 LTS Node versions ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Added Node v22 to the test suite ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [x] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
## [3.2.0](v3.1.9...v3.2.0) (2024-11-12) ### ✨ Features * add support for Node v22 ([#914](#914)) ([9147b20](9147b20)) ### ⚙️ Continuous Integrations * **action:** update actions/checkout action to v4.2.2 ([#880](#880)) ([293f54a](293f54a)) * **action:** update actions/checkout digest to 11bd719 ([#879](#879)) ([0287c69](0287c69)) * **action:** update actions/setup-node digest to 39370e3 ([#889](#889)) ([0f7a3aa](0f7a3aa)) * **action:** update actions/upload-artifact action to v4.4.3 ([#878](#878)) ([226ad5b](226ad5b)) * **action:** update step-security/harden-runner action to v2.10.1 ([#882](#882)) ([b09438e](b09438e)) ### ♻️ Chores * **deps:** lock file maintenance ([ad613cb](ad613cb)) * **deps:** update dependency [@fast-check](https://github.com/fast-check)/jest to v2.0.3 ([2d00739](2d00739)) * **deps:** update dependency [@semantic-release](https://github.com/semantic-release)/github to v11.0.1 ([a17bbdd](a17bbdd)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.6 ([4509c4d](4509c4d)) * **deps:** update dependency husky to v9 ([#844](#844)) ([9ea2216](9ea2216))
<!--- Provide a general summary of your changes in the Title above (following the Conventional Commits standard) --> <!-- More infos: https://www.conventionalcommits.org --> <!-- Commit types: https://github.com/insurgent-lab/conventional-changelog-preset#commit-types--> ## Description <!--- Describe your changes in detail --> Migrate .eslintrc to esling.config.mjs. Using .mjs so I can use `import` (.ts configs are still experimental). Fixed a few lint issues that were easy, changed one new lint rule to a warn since it wasn't caught before. ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> Fixes #899 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> Using the new flat config for Eslint is required for upgrading to 9.0 ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> Ran `npm run lint` and VS Code Eslint plugin many times ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
<!--- Provide a general summary of your changes in the Title above (following the Conventional Commits standard) --> <!-- More infos: https://www.conventionalcommits.org --> <!-- Commit types: https://github.com/insurgent-lab/conventional-changelog-preset#commit-types--> ## Description <!--- Describe your changes in detail --> add a pre-commit hook to run eslint on .ts files and prettify on JSON, MD, and YML files ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> fixes #907 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> a lot of times contributors make a PR just for it to fail because of linting/prettification requirements and have to manually run the linters locally and push a new commit with the fix. this change will lint/prettify on commit automatically, removing friction to contribution ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [ ] I have added tests to cover my changes. - [ ] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github/codeql-action](https://github.com/github/codeql-action) | action | patch | `v3.27.0` -> `v3.27.2` | [](https://securityscorecards.dev/viewer/?uri=github.com/github/codeql-action) | --- ### Release Notes <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.27.2`](https://github.com/github/codeql-action/releases/tag/v3.27.2) [Compare Source](https://github.com/github/codeql-action/compare/v3.27.1...v3.27.2) ##### CodeQL Action Changelog See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. Note that the only difference between `v2` and `v3` of the CodeQL Action is the node version they support, with `v3` running on node 20 while we continue to release `v2` to support running on node 16. For example `3.22.11` was the first `v3` release and is functionally identical to `2.22.11`. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers. ##### 3.27.2 - 12 Nov 2024 - Fixed an issue where setting up the CodeQL tools would sometimes fail with the message "Invalid value 'undefined' for header 'authorization'". [#​2590](https://github.com/github/codeql-action/pull/2590) See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.27.2/CHANGELOG.md) for more information. ### [`v3.27.1`](https://github.com/github/codeql-action/releases/tag/v3.27.1) [Compare Source](https://github.com/github/codeql-action/compare/v3.27.0...v3.27.1) ##### CodeQL Action Changelog See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. Note that the only difference between `v2` and `v3` of the CodeQL Action is the node version they support, with `v3` running on node 20 while we continue to release `v2` to support running on node 16. For example `3.22.11` was the first `v3` release and is functionally identical to `2.22.11`. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers. ##### 3.27.1 - 08 Nov 2024 - The CodeQL Action now downloads bundles compressed using Zstandard on GitHub Enterprise Server when using Linux or macOS runners. This speeds up the installation of the CodeQL tools. This feature is already available to github.com users. [#​2573](https://github.com/github/codeql-action/pull/2573) - Update default CodeQL bundle version to 2.19.3. [#​2576](https://github.com/github/codeql-action/pull/2576) See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.27.1/CHANGELOG.md) for more information. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kelektiv/node-cron). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS43LjEiLCJ1cGRhdGVkSW5WZXIiOiIzOS45LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [step-security/harden-runner](https://github.com/step-security/harden-runner) | action | patch | `v2.10.1` -> `v2.10.2` | [](https://securityscorecards.dev/viewer/?uri=github.com/step-security/harden-runner) | --- ### Release Notes <details> <summary>step-security/harden-runner (step-security/harden-runner)</summary> ### [`v2.10.2`](https://github.com/step-security/harden-runner/compare/v2.10.1...v2.10.2) [Compare Source](https://github.com/step-security/harden-runner/compare/v2.10.1...v2.10.2) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kelektiv/node-cron). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzkuMTkuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github/codeql-action](https://github.com/github/codeql-action) | action | patch | `v3.27.2` -> `v3.27.5` | [](https://securityscorecards.dev/viewer/?uri=github.com/github/codeql-action) | --- ### Release Notes <details> <summary>github/codeql-action (github/codeql-action)</summary> ### [`v3.27.5`](https://github.com/github/codeql-action/compare/v3.27.4...v3.27.5) [Compare Source](https://github.com/github/codeql-action/compare/v3.27.4...v3.27.5) ### [`v3.27.4`](https://github.com/github/codeql-action/releases/tag/v3.27.4) [Compare Source](https://github.com/github/codeql-action/compare/v3.27.3...v3.27.4) ##### CodeQL Action Changelog See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. Note that the only difference between `v2` and `v3` of the CodeQL Action is the node version they support, with `v3` running on node 20 while we continue to release `v2` to support running on node 16. For example `3.22.11` was the first `v3` release and is functionally identical to `2.22.11`. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers. ##### 3.27.4 - 14 Nov 2024 No user facing changes. See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.27.4/CHANGELOG.md) for more information. ### [`v3.27.3`](https://github.com/github/codeql-action/releases/tag/v3.27.3) [Compare Source](https://github.com/github/codeql-action/compare/v3.27.2...v3.27.3) ##### CodeQL Action Changelog See the [releases page](https://github.com/github/codeql-action/releases) for the relevant changes to the CodeQL CLI and language packs. Note that the only difference between `v2` and `v3` of the CodeQL Action is the node version they support, with `v3` running on node 20 while we continue to release `v2` to support running on node 16. For example `3.22.11` was the first `v3` release and is functionally identical to `2.22.11`. This approach ensures an easy way to track exactly which features are included in different versions, indicated by the minor and patch version numbers. ##### 3.27.3 - 12 Nov 2024 No user facing changes. See the full [CHANGELOG.md](https://github.com/github/codeql-action/blob/v3.27.3/CHANGELOG.md) for more information. </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kelektiv/node-cron). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45LjUiLCJ1cGRhdGVkSW5WZXIiOiIzOS4xOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [lint-staged](https://github.com/lint-staged/lint-staged) | devDependencies | pin | [`^15.2.10` -> `15.2.10`](https://renovatebot.com/diffs/npm/lint-staged/15.2.10/15.2.10) | [](https://securityscorecards.dev/viewer/?uri=github.com/lint-staged/lint-staged) | Add the preset `:preserveSemverRanges` to your config if you don't want to pin your dependencies. --- ### Configuration 📅 **Schedule**: Branch creation - "before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/kelektiv/node-cron). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS45LjUiLCJ1cGRhdGVkSW5WZXIiOiIzOS45LjUiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbImRlcGVuZGVuY2llcyJdfQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
## Description This PR improves async handling in the CronJob class and adds status tracking functionality. - Modified the `fireOnTick()` method to return a Promise for better async callback handling - Added an `isCallbackRunning` flag to track the running state of CronJob instances - Updated the test suite to use the new async behavior and track the job's running state - Added `waitForCompletion` functionality to the `job.stop()` method - waits for running jobs to complete before executing the `onComplete` callback During test case writing, I encountered a type error with sinon. To resolve this, added `sinon.restore()` to the `afterEach` block. Reference: https://stackoverflow.com/questions/73232999/sinon-cant-install-fake-timers-twice-on-the-same-global-object <img width="811" alt="스크린샷 2024-09-03 오후 7 10 58" src="https://github.com/user-attachments/assets/b87deee7-14b2-4407-8fea-a1cb469ef44b"> ## Related Issue Closes #713 Closes #556 ## Motivation and Context These changes allow the CronJob class to handle asynchronous callbacks more effectively and provide a way to track the running state of jobs. ## How Has This Been Tested? - Updated existing test suite to verify the new async behavior - Adjusted test timeouts to use the `tickAsync` method - Added new test cases to check for proper waiting of running callbacks before stopping ## Types of changes - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: - [x] My code follows the code style of this project. - [x] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard). --------- Co-authored-by: Brandon der Blätter <[email protected]>
## [3.3.0](v3.2.1...v3.3.0) (2024-12-10) ### ✨ Features * support async handling and add CronJob status tracking ([#894](#894)) ([b58fb6b](b58fb6b)), closes [#713](#713) [#556](#556) ### ⚙️ Continuous Integrations * **action:** update github/codeql-action action to v3.27.2 ([#912](#912)) ([d11ba30](d11ba30)) * **action:** update github/codeql-action action to v3.27.5 ([#917](#917)) ([2a4035e](2a4035e)) * **action:** update step-security/harden-runner action to v2.10.2 ([#920](#920)) ([26a8f9f](26a8f9f)) * add pre-commit hook to lint and prettify ([#911](#911)) ([e1140d1](e1140d1)), closes [#907](#907) ### ♻️ Chores * **deps:** lock file maintenance ([94465ae](94465ae)) * **deps:** lock file maintenance ([23d67a4](23d67a4)) * **deps:** lock file maintenance ([135fdf7](135fdf7)) * **deps:** lock file maintenance ([edcff3b](edcff3b)) * **deps:** pin dependency lint-staged to 15.2.10 ([#916](#916)) ([5cf24da](5cf24da)) * **deps:** update dependency [@commitlint](https://github.com/commitlint)/cli to v19.6.0 ([9d9ab94](9d9ab94)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.7 ([9181b6a](9181b6a)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.8 ([5899fc2](5899fc2)) * **deps:** update dependency [@types](https://github.com/types)/node to v20.17.9 ([ca5065a](ca5065a)) * **deps:** update dependency husky to v9.1.7 ([a960a29](a960a29)) * **deps:** update dependency typescript to v5.7.2 ([3447ff5](3447ff5))
<!--- Provide a general summary of your changes in the Title above (following the Conventional Commits standard) --> <!-- More infos: https://www.conventionalcommits.org --> <!-- Commit types: https://github.com/insurgent-lab/conventional-changelog-preset#commit-types--> ## Description <!--- Describe your changes in detail --> fixes #923 ## Related Issue <!--- This project only accepts pull requests related to open issues --> <!--- If suggesting a new feature or change, please discuss it in an issue first --> <!--- If fixing a bug, there should be an issue describing it with steps to reproduce --> <!--- Please link to the issue here: --> #923 ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> it makes the new feature actually work ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> modified test case added by #894 ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the code style of this project. - [ ] My change requires a change to the documentation. - [ ] I have updated the documentation accordingly. - [x] I have added tests to cover my changes. - [x] All new and existing tests passed. - [ ] If my change introduces a breaking change, I have added a `!` after the type/scope in the title (see the Conventional Commits standard).
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.