-
-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix RCS1211 #1095
Merged
Merged
Fix RCS1211 #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefpihrt
requested changes
Jul 11, 2023
src/Analyzers/CSharp/Analysis/SwitchLocallyDeclaredVariablesHelper.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/SwitchLocallyDeclaredVariablesHelper.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/SwitchLocallyDeclaredVariablesHelper.cs
Outdated
Show resolved
Hide resolved
@jamesHargreaves12 sorry the late review. |
Co-authored-by: Josef Pihrt <[email protected]>
…lper.cs Co-authored-by: Josef Pihrt <[email protected]>
…lper.cs Co-authored-by: Josef Pihrt <[email protected]>
…lper.cs Co-authored-by: Josef Pihrt <[email protected]>
josefpihrt
approved these changes
Jul 12, 2023
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
Co-authored-by: Josef Pihrt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing unnecessary else blocks we need to also check if it conflicts with any other switch blocks (If the else is located at the top level of a switch selection).
e.g. in the following example, we cannot apply RCS1211 to remove the else.
The logic here is identical to removing the braces around the switch statements and so I just refactored that method out into its own helper class.