From 560f004e03b2bf7d2a5fe492dd899fbecf95d24c Mon Sep 17 00:00:00 2001 From: shbatm Date: Fri, 4 Jan 2019 13:40:04 -0600 Subject: [PATCH] Fix Jopyth/MMM-Remote-Control#87 - Unhandled Error --- node_helper.js | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/node_helper.js b/node_helper.js index 1eda825..0622666 100644 --- a/node_helper.js +++ b/node_helper.js @@ -211,7 +211,7 @@ module.exports = NodeHelper.create(Object.assign({ // now check for installed modules fs.readdir(path.resolve(__dirname + "/.."), function(err, files) { let installedModules = files.filter(f => ['node_modules', 'default', 'README.md'].indexOf(f) === -1); - installedModules.forEach((dir, i) => { + installedModules.forEach((dir, i, a) => { self.addModule(dir, (i === installedModules.length - 1)); }); }); @@ -273,11 +273,16 @@ module.exports = NodeHelper.create(Object.assign({ if (error) { console.log(error); } - var baseUrl = result[0].refs.fetch; - // replacements - baseUrl = baseUrl.replace(".git", "").replace("github.com:", "github.com/"); - // if cloned with ssh - currentModule.url = baseUrl.replace("git@", "https://"); + try { + var baseUrl = result[0].refs.fetch; + // replacements + baseUrl = baseUrl.replace(".git", "").replace("github.com:", "github.com/"); + // if cloned with ssh + currentModule.url = baseUrl.replace("git@", "https://"); + } catch (e) { + // Something happened. Skip it. + return; + } }); } }