Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why it would be better to get rid of time_machine #33

Open
JulianKowalczuk opened this issue Jul 11, 2020 · 0 comments
Open

Why it would be better to get rid of time_machine #33

JulianKowalczuk opened this issue Jul 11, 2020 · 0 comments
Labels
T: Feature Type: :tada: New Features

Comments

@JulianKowalczuk
Copy link

JulianKowalczuk commented Jul 11, 2020

So... You use time_machine for datetime usage purpose. I see pros of usage it, but...

  1. time_machine is forbidden by its author. Many PRs with 0 replies, there is no repo activity for MONTHS (even in other projects). Since Your package relies on it, all bugs from time_machine breaks Your package also :/

  2. [Web] Get stuck at initialize call Dana-Ferguson/time_machine#27
    This one breaks production build for web, so time_machine is not for web in current build and Your package too...

  3. flutter initialize failed Dana-Ferguson/time_machine#34
    I didn't test it, but I'm using similar version of Flutter build and it probably breaks iOS also...

Since many people works with native types, I think better solution is to use native DateTime.
I'm ready to put my effort to get rid of it, since I really like Your package and it's better to improve current one instead forking new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T: Feature Type: :tada: New Features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant