Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off directives into imagetools-core #17

Closed
7 of 11 tasks
JonasKruckenberg opened this issue Mar 10, 2021 · 2 comments · Fixed by #58
Closed
7 of 11 tasks

Split off directives into imagetools-core #17

JonasKruckenberg opened this issue Mar 10, 2021 · 2 comments · Fixed by #58
Labels
enhancement New feature or request

Comments

@JonasKruckenberg
Copy link
Owner

JonasKruckenberg commented Mar 10, 2021

I feel like vite-imagetools has potential to grow beyond vite and possibly have rollup, webpack, cli, etc. versions.

This is why I'm looking to split off the directives and core logic into it's own repository.

And this issue will keep track of progress towards that goal

The refactor roadmap

  • rename the repository to imagetools
  • make in a monorepo
  • create core/lib package
  • move directives to core
  • improve core unit tests
  • create vite package
  • update awesome Vite link
  • create rollup package
  • add to awesome rollup repo
  • create cli package
  • create server version ?
@JonasKruckenberg JonasKruckenberg added the enhancement New feature or request label Mar 10, 2021
@yamiteru
Copy link

This is an absolutely amazing idea! Sometimes I can't use a framework I like and often those frameworks don't even use vite. It'd be awesome if we could use this library in any framework. I'm afraid that some features might not be available in some of the bundlers or they will have to be patched using other plugins so it might quickly grow out of hands.

@JonasKruckenberg
Copy link
Owner Author

Yeah it's definitely something to keep an eye out for!
I think a rollup integration should be straightforward as Vite is basically rollup with more quirks (some might even call it features 😄). I don't know enough about Webpack or parcel to make any guesses to how a plugin for those would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants