Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New BIP21 parsing can crash without amount argument #1356

Closed
AdamISZ opened this issue Sep 25, 2022 · 1 comment · Fixed by #1357
Closed

New BIP21 parsing can crash without amount argument #1356

AdamISZ opened this issue Sep 25, 2022 · 1 comment · Fixed by #1357
Labels
bug

Comments

@AdamISZ
Copy link
Member

AdamISZ commented Sep 25, 2022

This line in the recent PR #1316 :

83c6bc0#diff-356214049d76dbbbdccc6357196ae5fb5f709f40a8a0b9da84a18d9559de6ad8R99

doesn't handle the case where the user does:

python sendpayment.py <options> wallet.jmdat "BIP21URI"

since there the length of args is 2 so, not 3+.

Discovered when trying to do a payjoin.
@AdamISZ AdamISZ added the bug label Sep 25, 2022
@kristapsk
Copy link
Member

It's my code, will look at it and fix.

@kristapsk kristapsk mentioned this issue Sep 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix sendpayment without amount argument, BIP21 only kristapsk/joinmarket-clientserver
2 participants
@AdamISZ @kristapsk