Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added option to enable proposed features #602

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

edgardmessias
Copy link
Contributor

@edgardmessias edgardmessias commented Jun 5, 2019

Currently we can not publish extensions with "enableProposedApi"= true.

This pull make two options:

  • Add to allowed use of proposed API on product.json
  • Set "enableProposedApi"= true after install, to allow start with code --enable-proposed-api johnstoncode.svn-scm

@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #602 into master will increase coverage by 0.19%.
The diff coverage is 47.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   57.37%   57.57%   +0.19%     
==========================================
  Files         113      115       +2     
  Lines        4272     4346      +74     
  Branches      624      636      +12     
==========================================
+ Hits         2451     2502      +51     
- Misses       1590     1617      +27     
+ Partials      231      227       -4
Impacted Files Coverage Δ
src/helpers/configuration.ts 60% <0%> (ø) ⬆️
src/extension.ts 70.96% <100%> (+0.63%) ⬆️
src/fs/index.ts 100% <100%> (ø) ⬆️
src/model.ts 60.25% <100%> (+0.58%) ⬆️
src/proposed.ts 40.9% <40.9%> (ø)
src/fs/access.ts 75% <75%> (ø)
src/repository.ts 62.88% <0%> (+2.18%) ⬆️
src/statusParser.ts 76.31% <0%> (+2.63%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f16c9f4...77bcd0d. Read the comment docs.

@JohnstonCode
Copy link
Owner

@edgardmessias lint issues run lint:fix

@edgardmessias
Copy link
Contributor Author

@JohnstonCode, done

@JohnstonCode JohnstonCode self-requested a review June 7, 2019 10:07
Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix grammar

@JohnstonCode JohnstonCode self-requested a review June 7, 2019 12:14
@JohnstonCode JohnstonCode merged commit 3eedbb5 into JohnstonCode:master Jun 7, 2019
JohnstonCode added a commit that referenced this pull request Jun 7, 2019
# [1.53.0](v1.52.2...v1.53.0) (2019-06-07)

### Features

* Added option to enable proposed features ([#602](#602)) ([3eedbb5](3eedbb5))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.53.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants