Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow multi-line commit messages (close #471) #589

Merged
merged 5 commits into from
Jun 3, 2019
Merged

feat: Allow multi-line commit messages (close #471) #589

merged 5 commits into from
Jun 3, 2019

Conversation

edgardmessias
Copy link
Contributor

Note: run before: npm install && npm run build

A solution to allow multi-line commit message, with webview

@codecov
Copy link

codecov bot commented May 30, 2019 •
edited
Loading

Codecov Report

Merging #589 into master will increase coverage by 0.43%.
The diff coverage is 67.39%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #589      +/-   ##
=========================================
+ Coverage   57.36%   57.8%   +0.43%     
=========================================
  Files         113     113              
  Lines        4220    4259      +39     
  Branches      614     620       +6     
=========================================
+ Hits         2421    2462      +41     
+ Misses       1574    1573       -1     
+ Partials      225     224       -1
Impacted Files Coverage Δ
src/extension.ts 70.32% <100%> (+0.66%) ⬆️
src/commands/commit.ts 65.11% <100%> (ø) ⬆️
src/commands/commitWithMessage.ts 72.22% <33.33%> (ø) ⬆️
src/messages.ts 63.26% <66.66%> (+4.93%) ⬆️
src/repository.ts 62.88% <0%> (+1.96%) ⬆️
src/statusParser.ts 76.31% <0%> (+2.63%) ⬆️
src/statusbar/syncStatusBar.ts 84.84% <0%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42895a9...e894bbd. Read the comment docs.

@edgardmessias
Copy link
Contributor Author

edgardmessias commented May 30, 2019 •
edited
Loading

Some print, the colors respect the theme:
image
image
image

@JohnstonCode
Copy link
Owner

If i write a commit message and click cancel i get this empty .git created

image

JohnstonCode
JohnstonCode requested changes Jun 1, 2019
View reviewed changes
Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above

@edgardmessias
Copy link
Contributor Author

O will check

@edgardmessias
Copy link
Contributor Author

@JohnstonCode, I can't reproduce the bug with ".git" folder

@JohnstonCode
Copy link
Owner

I will re-test tonight

@JohnstonCode
Copy link
Owner

Seems my vs is bugged

@JohnstonCode JohnstonCode self-requested a review June 3, 2019 19:54
@JohnstonCode JohnstonCode merged commit bb06651 into JohnstonCode:master Jun 3, 2019
JohnstonCode added a commit that referenced this pull request Jun 3, 2019
@JohnstonCode
chore(release): 1.52.0 [skip ci]
3b5e2bb 
# [1.52.0](v1.51.0...v1.52.0) (2019-06-03)

### Features

* Allow multi-line commit messages (close [#471](#471)) ([#589](#589)) ([bb06651](bb06651))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.52.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edgardmessias edgardmessias mentioned this pull request Jun 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgardmessias @JohnstonCode