Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Show alert to work with code-server #579

Merged
merged 1 commit into from
May 21, 2019
Merged

fix: Show alert to work with code-server #579

merged 1 commit into from
May 21, 2019

Conversation

edgardmessias
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented May 17, 2019 •
edited
Loading

Codecov Report

Merging #579 into master will decrease coverage by 0.05%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   57.72%   57.66%   -0.06%     
==========================================
  Files         111      111              
  Lines        4102     4108       +6     
  Branches      593      583      -10     
==========================================
+ Hits         2368     2369       +1     
- Misses       1521     1526       +5     
  Partials      213      213
Impacted Files Coverage Δ
src/vscodeModules.ts 61.53% <50%> (-38.47%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd982c8...3357f79. Read the comment docs.

JohnstonCode
JohnstonCode approved these changes May 21, 2019
View reviewed changes
Copy link
Owner

@JohnstonCode JohnstonCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. Been thinking if there was a better way to handle this. Cant think of one so this is the best we can do for them without increasing the vsix size for everyone.

@JohnstonCode JohnstonCode merged commit 605b321 into JohnstonCode:master May 21, 2019
JohnstonCode added a commit that referenced this pull request May 21, 2019
@JohnstonCode
chore(release): 1.48.5 [skip ci]
48ff9dc 
## [1.48.5](v1.48.4...v1.48.5) (2019-05-21)

### Bug Fixes

* Show alert to work with code-server ([#579](#579)) ([605b321](605b321))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.48.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

@edgardmessias edgardmessias deleted the code-server branch June 3, 2019 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnstonCode JohnstonCode JohnstonCode approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edgardmessias @JohnstonCode