Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hist lens #440

Merged
merged 91 commits into from
Dec 21, 2018
Merged

Hist lens #440

merged 91 commits into from
Dec 21, 2018

Conversation

Yanpas
Copy link
Contributor

@Yanpas Yanpas commented Dec 19, 2018

Boom :)

@JohnstonCode JohnstonCode self-requested a review December 20, 2018 09:30
@JohnstonCode
Copy link
Owner

I will fully review this tomorrow as I am free all day.

@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 20, 2018

CHANGELOG.md was prettified by some git hook, very annoying. With --no-verify no it's identaical.

@JohnstonCode
Copy link
Owner

Can you remove all the getCommitIcon and just use a generic icon for a person or no icon at all?

@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 20, 2018

Can you remove all the getCommitIcon and just use a generic icon for a person or no icon at all?

Gravatar icons help track author visually, they exist in gitlens for the same reason. So I don't think it's a good idea.

Mine avatar is red robot e.g.:
image

@JohnstonCode
Copy link
Owner

Actually thinking about it, some differentiation is good.

@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 20, 2018

It doesn't expose any data since hash is transmitted. I think users won't just find this option in settings and will use default. If there is no network there will be no icons and network overhead is low. (I think chrome caches equal urls)

Concerning screenshot - line without avatar is BASE, just marker of current revision.

@JohnstonCode
Copy link
Owner

This Item history bit. Is there a way it can display the item it's showing the history for?

@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 20, 2018

What do you mean? Item History shows svn log of active file. Do you mean right-click on some file in the whole log and click open history of this item? user may open this file locally (if it exists in BASE) and item history will be updated automatically

@JohnstonCode
Copy link
Owner

I mean in the item log where is no way to easily identify what the item log is for.

@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 21, 2018

We may rename it to file history and/or add root item with it's name like in gitlens:
image

@JohnstonCode
Copy link
Owner

Yes!

@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 21, 2018

done
image

@JohnstonCode
Copy link
Owner

the root item has the copy message to clipboard context menu on it

@JohnstonCode
Copy link
Owner

Yeah all looks good now.

@JohnstonCode JohnstonCode merged commit 35988d1 into JohnstonCode:master Dec 21, 2018
@Yanpas
Copy link
Contributor Author

Yanpas commented Dec 21, 2018

woohoo 😄

JohnstonCode added a commit that referenced this pull request Dec 21, 2018
# [1.47.0](v1.46.4...v1.47.0) (2018-12-21)

### Bug Fixes

* Created matchAll function wrapper for minimatch so dir globs are properly ignored ([#432](#432)) ([dda6f13](dda6f13))

### Features

* Added History lens ([#440](#440)) ([35988d1](35988d1))
@JohnstonCode
Copy link
Owner

🎉 This PR is included in version 1.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Nukium
Copy link

Nukium commented Jan 2, 2019

Awesome !!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants