fix: Fixed 'split' of undefined (close #611) (#678)

edgardmessias · JohnstonCode · commit d6d3369e23eb · 2019-10-08T11:17:41.000Z
diff --git a/src/historyView/common.ts b/src/historyView/common.ts
@@ -220,8 +220,11 @@ export function getCommitIcon(
 }
 
 export function getCommitLabel(commit: ISvnLogEntry): string {
-  const fstLine = commit.msg.split(/\r?\n/, 1)[0];
-  return `${fstLine} • r${commit.revision}`;
+  let commitMsg = "<blank>";
+  if (commit.msg) {
+    commitMsg = commit.msg.split(/\r?\n/, 1)[0];
+  }
+  return `${commitMsg} • r${commit.revision}`;
 }
 
 export function getCommitToolTip(commit: ISvnLogEntry): string {

Original file line number	Diff line number	Diff line change
`@@ -220,8 +220,11 @@ export function getCommitIcon(`
`220`	`220`	`}`
`221`	`221`
`222`	`222`	`export function getCommitLabel(commit: ISvnLogEntry): string {`
`223`		`- const fstLine = commit.msg.split(/\r?\n/, 1)[0];`
`224`		- return `${fstLine} • r${commit.revision}`;
	`223`	`+ let commitMsg = "<blank>";`
	`224`	`+ if (commit.msg) {`
	`225`	`+ commitMsg = commit.msg.split(/\r?\n/, 1)[0];`
	`226`	`+ }`
	`227`	+ return `${commitMsg} • r${commit.revision}`;
`225`	`228`	`}`
`226`	`229`
`227`	`230`	`export function getCommitToolTip(commit: ISvnLogEntry): string {`