fix: Removed proposed api (#690)

BREAKING CHANGE: Removed proposed api functionallity (#675)

Author: JohnstonCode

README.md

@@ -60,30 +60,6 @@ If you use [TortoiseSVN](https://tortoisesvn.net/), make sure the option
 
 Please use a dedicated extension like [blamer-vs](https://marketplace.visualstudio.com/items?itemName=beaugust.blamer-vs)
 
-## Experimental
-
-### * SVN Status in File Explorer (See [#34](https://github.com/JohnstonCode/svn-scm/issues/34))
-How to enable:
-* Open the file: `<vscode path>\resources\app\product.json`
-* Find `extensionAllowedProposedApi`
-* Append `"johnstoncode.svn-scm"` in the array
-
-Example:
-```js
-// FROM
-{
-  "extensionAllowedProposedApi": [
-    "ms-vsliveshare.vsliveshare"
-  ]
-}
-// TO
-{
-  "extensionAllowedProposedApi": [
-    "ms-vsliveshare.vsliveshare", "johnstoncode.svn-scm"
-  ]
-}
-```
-
 ## Settings
 Here is a table of settings with their default values. To change any of these, add the relevant Config key and value to your VSCode settings.json file.
 

package-lock.json

@@ -372,11 +372,6 @@
           "dark": "icons/dark/clean.svg"
         }
       },
-      {
-        "command": "svn.revertSelectedRanges",
-        "title": "Revert Selected Ranges",
-        "category": "SVN"
-      },
       {
         "command": "svn.close",
         "title": "Close repository",
@@ -530,10 +525,6 @@
           "command": "svn.revertAll",
           "when": "false"
         },
-        {
-          "command": "svn.revertSelectedRanges",
-          "when": "config.svn.enabled && svnOpenRepositoryCount != 0 && svnHasSupportToRegisterDiffCommand == 1"
-        },
         {
           "command": "svn.close",
           "when": "config.svn.enabled && svnOpenRepositoryCount != 0"
@@ -891,11 +882,6 @@
           "command": "svn.openChangeHead",
           "group": "navigation",
           "when": "config.svn.enabled && svnOpenRepositoryCount != 0 && svnActiveEditorHasChanges && !isInDiffEditor && resourceScheme == file"
-        },
-        {
-          "command": "svn.revertSelectedRanges",
-          "group": "2_svn@3",
-          "when": "config.svn.enabled && svnOpenRepositoryCount != 0 && isInDiffEditor && resourceScheme != merge-conflicts.conflicts-diff && svnHasSupportToRegisterDiffCommand == 1"
         }
       ],
       "explorer/context": [

package.json

@@ -38,7 +38,6 @@ import { Revert } from "./commands/revert";
 import { RevertAll } from "./commands/revertAll";
 import { RevertChange } from "./commands/revertChange";
 import { RevertExplorer } from "./commands/revertExplorer";
-import { RevertSelectedRanges } from "./commands/revertSelectedRanges";
 import { SwitchBranch } from "./commands/switchBranch";
 import { Update } from "./commands/update";
 import { Upgrade } from "./commands/upgrade";
@@ -77,7 +76,6 @@ export function registerCommands(model: Model, disposables: Disposable[]) {
   disposables.push(new AddToIgnoreExplorer());
   disposables.push(new RenameExplorer());
   disposables.push(new Upgrade());
-  disposables.push(new RevertSelectedRanges());
   disposables.push(new OpenChangePrev());
   disposables.push(new PromptRemove());
   disposables.push(new Checkout());

src/commands.ts

@@ -2,7 +2,6 @@ import * as path from "path";
 import {
   commands,
   Disposable,
-  LineChange,
   Position,
   Range,
   SourceControlResourceState,
@@ -14,7 +13,12 @@ import {
   workspace,
   WorkspaceEdit
 } from "vscode";
-import { ICommandOptions, Status, SvnUriAction } from "../common/types";
+import {
+  ICommandOptions,
+  Status,
+  SvnUriAction,
+  LineChange
+} from "../common/types";
 import { exists, readFile, stat, unlink } from "../fs";
 import { inputIgnoreList } from "../ignoreitems";
 import { applyLineChanges } from "../lineChanges";
@@ -23,7 +27,6 @@ import { Repository } from "../repository";
 import { Resource } from "../resource";
 import IncomingChangeNode from "../treeView/nodes/incomingChangeNode";
 import { fromSvnUri, toSvnUri } from "../uri";
-import { hasSupportToRegisterDiffCommand } from "../util";
 
 export abstract class Command implements Disposable {
   private _disposable?: Disposable;
@@ -37,14 +40,6 @@ export abstract class Command implements Disposable {
       return;
     }
 
-    if (options.diff && hasSupportToRegisterDiffCommand()) {
-      this._disposable = commands.registerDiffInformationCommand(
-        commandName,
-        (...args: any[]) => this.execute(...args)
-      );
-      return;
-    }
-
     if (!options.repository) {
       this._disposable = commands.registerCommand(
         commandName,

src/commands/command.ts

@@ -1,5 +1,6 @@
-import { LineChange, Uri, window } from "vscode";
+import { Uri, window } from "vscode";
 import { Command } from "./command";
+import { LineChange } from "../common/types";
 
 export class RevertChange extends Command {
   constructor() {

src/commands/revertChange.ts

@@ -289,3 +289,10 @@ export enum SvnDepth {
   immediates = "the target and any immediate children thereof",
   infinity = "the target and all of its descendants—full recursion"
 }
+
+export interface LineChange {
+  readonly originalStartLineNumber: number;
+  readonly originalEndLineNumber: number;
+  readonly modifiedStartLineNumber: number;
+  readonly modifiedEndLineNumber: number;
+}