Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to build #361

Closed
theoparis opened this issue May 8, 2023 · 2 comments
Closed

Fails to build #361

theoparis opened this issue May 8, 2023 · 2 comments

Comments

@theoparis
Copy link

theoparis commented May 8, 2023

The errors I received:

/mnt/share/projects/luau-lsp/extern/json/include/nlohmann/json.hpp:19914:10: note: candidate template ignored: substitution failure [with PointerType = lsp::InitializeParams::ClientInfo]: no matching member function for call to 'get_ptr'
    auto get() noexcept -> decltype(std::declval<basic_json_t&>().template get_ptr<PointerType>())
         ^                                                                 ~~~~~~~
In file included from /mnt/share/projects/luau-lsp/src/operations/DocumentLink.cpp:1:
In file included from /mnt/share/projects/luau-lsp/src/include/LSP/Workspace.hpp:5:
In file included from /mnt/share/projects/luau-lsp/src/include/Protocol/Structures.hpp:7:
/mnt/share/projects/luau-lsp/src/include/Protocol/Base.hpp:50:21: error: no matching member function for call to 'get'
            opt = j.get<T>();

/mnt/share/projects/luau-lsp/src/LuauExt.cpp:529:65: error: reference to non-static member function must be called; did you mean to call it with no arguments?

The command I used to build luau-lsp:

git submodule update --remote --jobs 12 --depth 1 --progress --init
cmake -B build -G Ninja -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_CXX_COMPILER=clang++-17
ninja -C build

Edit: might be related to nlohmann/json#3979

@JohnnyMorganz
Copy link
Owner

Sorry, I'm not sure what the problem would be here. It builds fine for me and in CI.
Maybe the compiler version is the issue?

Is there a reason you wish to build from source here? Maybe one of the prebuilt binaries may be sufficient for you

@JohnnyMorganz
Copy link
Owner

Going to close this issue for now. If you have any more problems, do let me know

@JohnnyMorganz JohnnyMorganz closed this as not planned Won't fix, can't repro, duplicate, stale May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants