Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VSCode extension setting for config path(s) #560

Closed
filiptibell opened this issue Aug 31, 2022 · 2 comments · Fixed by #568
Closed

VSCode extension setting for config path(s) #560

filiptibell opened this issue Aug 31, 2022 · 2 comments · Fixed by #568
Labels
enhancement New feature or request extension Concerns the VSCode extension

Comments

@filiptibell
Copy link
Contributor

When using a multi-root workspace we currently have to duplicate the same stylua.toml into each workspace root, it would be great to have a setting to point the VSCode extension to a config at the root of the repository instead.

A respective config for .styluaignore may also be necessary but I'm not sure if the CLI accepts a path arg for that?

@JohnnyMorganz
Copy link
Owner

I'm assuming the config file is present in some ancestor directory that both projects are part of?

This could probably be solved if we exposed --search-parent-directories as an option to configure in the extension

@JohnnyMorganz JohnnyMorganz added extension Concerns the VSCode extension enhancement New feature or request labels Aug 31, 2022
@filiptibell
Copy link
Contributor Author

filiptibell commented Aug 31, 2022

I'm assuming the config file is present in some ancestor directory that both projects are part of?

Yup, the full repo looks something like this:

packages/foo/...
packages/bar/...
packages/baz/...
stylua.toml

So just a pretty basic monorepo layout where most/all shared config should sit at the root, if possible.
Exposing --search-parent-directories would definitely solve this 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request extension Concerns the VSCode extension
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants